Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dash-shaka-playback is not updated with Shaka version above 2.5.5 #77

Open
yvashar opened this issue Mar 6, 2020 · 0 comments
Open

dash-shaka-playback is not updated with Shaka version above 2.5.5 #77

yvashar opened this issue Mar 6, 2020 · 0 comments

Comments

@yvashar
Copy link

yvashar commented Mar 6, 2020

The TTML subtitles had some styling issues with dash-shaka-playback and the styling is proper in standalone shaka-player ^2.5.6. When the dash-shaka-playback source code is inspected , the fix for TTML subtitles styling was missing in the dash-shaka-playback.js

Please see below TTML subtitle styling fix given by shaka-player.
shaka-project/shaka-player@9f7652e

Also, dash-shaka-playback seems to pick the older shaka-player version rather picking the latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yvashar