Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync doesn't update files when filesize is same, but content mismatches #27

Closed
krunk4ever opened this issue Feb 26, 2014 · 3 comments
Closed

Comments

@krunk4ever
Copy link

I've noticed that if the old file and the new file are the same size, they don't get synced. Most of these cases are text files which have same-length strings updated, resulting in the same file size.

If I go ahead and add/remove 1 character from the text file, sync will update the file.

@amiel
Copy link
Contributor

amiel commented Mar 15, 2014

I'm also having this problem. I'm assuming there's not a hash comparison since that would require downloading the file from s3.

Would it be possible to compare the updated time?

@clarete
Copy link
Owner

clarete commented Mar 21, 2014

Just merged #29. I guess also it closes this issue. Please reopen the ticket if there's still something to be addressed. Thank you!

@clarete clarete closed this as completed Mar 21, 2014
@amiel
Copy link
Contributor

amiel commented Mar 21, 2014

Oh yeah, I meant to reference this issue in my pull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants