-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the JSON / PSOL radio buttons #3
Comments
Hmm, I agree that's confusing. The buttons are to tell the server whether to interpret the program as PSOL or JSOL, so they are necessary. For example, write a program in JSOL and check the PSOL button, and you'll get an error. I would like to clean up the interface though to make that more clear. Any suggestions? |
Replace the radio buttons with the selection and eval button side by side. |
The POST is already passing additional parameters (thats what the PSOL/JSOL radio buttons are for). The problem is that if a user types in arbitrary code into the box, there is no way to tell if it is PSOL or JSOL. I could try to run it as PSOL, and if I get an exception fall back to JSOL, but thats pretty hacky and will return the wrong error messages in some cases. |
Isn't JSOL valid JSON, while PSOL isn't? I think it would be better if you separated the two sources. Have JSOL on one side and PSOL on the other. Anyhow it seems ok with the current version because I just now realized that the text box allows the user to parse custom JSOL/PSOL. I original thought it was only to display code. |
On the homepage, I think you should remove the JSOL and PSOL radio buttons since they don't update the view automatically and also they don't work.
Cool project by the way.
The text was updated successfully, but these errors were encountered: