Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask content of title attribute in profile #29

Open
peterblazejewicz opened this issue Jan 21, 2018 · 3 comments
Open

Mask content of title attribute in profile #29

peterblazejewicz opened this issue Jan 21, 2018 · 3 comments

Comments

@peterblazejewicz
Copy link

peterblazejewicz commented Jan 21, 2018

The title attribute contains the same sensitive information that is covered by blurred style.
Can the string replacement be used here? At least in the main navigation menu.

The below appears to implement the idea:

regex = /^(?:\b\w*\b:){1}(?:\s)(.*)$/gmi;
match = null;

while((match = regex.exec(title)) !== null) {
  group = match[1];
  newTitle = newTitle.replace(group, group.replace(/[\S]/g, '*'));
}
"Name: ***** ***********
Email: ***************************
Directory: ******* ******** **************************************
Domain: *************************************"

thanks!

@clarkio
Copy link
Owner

clarkio commented Feb 15, 2018

Hi @peterblazejewicz thanks for taking the time to open and report this issue you're seeing. Could you share an example of where/which title attribute is in the portal showing this? It will help me better understand the issue.

@peterblazejewicz
Copy link
Author

Hi,
Yes, sure. The top navigation bar user info section:

image

This can be a tiny problem, assuming it is rarely triggered.

Thanks!

@clarkio
Copy link
Owner

clarkio commented Apr 19, 2019

Me again and back to working on this project a bit :)

I'm trying to determine the best solution here as I'd like to also avoid storing any data that is hidden by the extension. Being that the nature of the extension is to just hide/show the sensitive data if we were to start replacing the sensitive data to hide it (such as in the possible solution to this issue) we'd need to know how to return it back when the extension is toggled off.

One solution I'm exploring and what I plan to use to resolve other title/tooltip masking issues (such as in #48) is to disable pointer-events. The downside of doing that here is you won't be able to access the user menu then.

I'm open to hearing other ideas and suggestions on how we can best resolve this as well. Please feel free to share here if you or anyone else has some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants