add Annotations/Attributes to InstDecl

[hcab14]

This PR is related to #1423

I hope I did not break anything. stack test does not show errors related to this PR (I think):

Test suite failure for package clash-prelude-1.3.0
doctests:  exited with: ExitFailure 1

and

clash-prelude> /home/cmayer/Software/clash-compiler/clash-prelude/src/Clash/XException.hs:141: failure in expression `h' (errorX "QQ") 3'                                                                          
clash-prelude> expected: 0000_0011                                                                                                                                                                                 
clash-prelude>  but got:                                                                                                                                                                                           
clash-prelude>           ^                                                                                                                                                                                         
clash-prelude>           <interactive>:13170:1: error:                                                                                                                                                             
clash-prelude>               Variable not in scope: h' :: t0 -> Integer -> t                                                                                                                                       
clash-prelude>                                                                                                                                                                                                     
clash-prelude> /home/cmayer/Software/clash-compiler/clash-prelude/src/Clash/XException.hs:197: failure in expression `h' (errorX "QQ") 3'                                                                          
clash-prelude> expected: 0000_0011                                                                                                                                                                                 
clash-prelude>  but got:                                                                                                                                                                                           
clash-prelude>           ^                                                                                                                                                                                         
clash-prelude>           <interactive>:13200:1: error:                                                                                                                                                             
clash-prelude>               Variable not in scope: h' :: t0 -> Integer -> t                                                                                                                                       
clash-prelude>                                                                                                                                                                                                     
clash-prelude> Examples: 806  Tried: 804  Errors: 0  Failures: 2                                                                                                                                                   

[martijnbastiaan]

Hi @hcab14. Thanks for the PR, looks good!

A couple of things:

• Could you add a CHANGELOG entry? See: https://github.com/clash-lang/clash-compiler/blob/master/changelog/README.md for instructions.

• I have no clue what triggers the failure in the doctests. I've seen it before, but strangely never on the CI. I'll report an issue. Fixed: Use let when using type signatures #1483. If you rebase you should be good.

• It would be nice if you could add an example to tests/shouldwork/SynthesisAttributes. Writing an actual tests is a bit annoying for this kind of stuff, so I wouldn't mind taking over from there.

[hcab14]

HI @martijnbastiaan

thank you for your review.

• Could you add a CHANGELOG entry? See: https://github.com/clash-lang/clash-compiler/blob/master/changelog/README.md for instructions.

Done. I am not sure under which category this change should be, e.g., "new feature (API)" or "new internal feature".

• It would be nice if you could add an example to tests/shouldwork/SynthesisAttributes. Writing an actual tests is a bit annoying for this kind of stuff, so I wouldn't mind taking over from there.

See tests/shouldwork/SynthesisAttributes/InstDeclAnnotations.hs for a first attempt.

[alex-mckenna]

Done. I am not sure under which category this change should be, e.g., "new feature (API)" or "new internal feature".

As the change is mostly to InstDecl, I would say internal feature. Although I would defer to @martijnbastiaan if he disagrees :)

[martijnbastiaan]

Agreed @alex-mckenna!

@hcab14 Looks real nice, thanks again :).