TDP BRAM: also swap names #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on which clock is faster, we swap port A and B of the TDP BRAM in the Haskell model. But the XExceptions mentioning port names then confusingly named the wrong port. Now the names correspond to what the user wrote.
DigitalBrains1
force-pushed
the
tdplabels
branch
from
3ef785b
to
7318568
Compare
martijnbastiaan
approved these changes
Feb 24, 2022
mergify bot
pushed a commit
that referenced
this pull request
Feb 24, 2022
Depending on which clock is faster, we swap port A and B of the TDP BRAM in the Haskell model. But the XExceptions mentioning port names then confusingly named the wrong port. Now the names correspond to what the user wrote. (cherry picked from commit 89e3f35)
martijnbastiaan
pushed a commit
that referenced
this pull request
Feb 24, 2022
Depending on which clock is faster, we swap port A and B of the TDP BRAM in the Haskell model. But the XExceptions mentioning port names then confusingly named the wrong port. Now the names correspond to what the user wrote. (cherry picked from commit 89e3f35) Co-authored-by: Peter Lebbing <peter@digitalbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on which clock is faster, we swap port A and B of the TDP BRAM
in the Haskell model. But the XExceptions mentioning port names then
confusingly named the wrong port. Now the names correspond to what the
user wrote.
Still TODO: