Fix and document Altera PLL's #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DigitalBrains1
force-pushed
the
alterapll
branch
from
bfac719
to
9fd204e
Compare
alex-mckenna
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
LGTM. While we're editing around here though: is it worth referring users to look at the data sheet to see what clocks they can ask for. I assume the speed of clocks you can generate is determined by the board you're using or something? Even if it's obvious to hardware engineers, it feels like something that makes it friendlier to hobbyists etc.
|
This is what you get for recently doing a documentation PR, I actually thought about the documentation while reviewing 😉 |
DigitalBrains1
force-pushed
the
alterapll
branch
from
9fd204e
to
13a307c
Compare
|
Okay, you motivated me to write more documentation for this module. How's this? (note: build artifact of CI, will disappear next time CI runs for this PR) |
|
This looks much better to me, but I think @leonschoorl or @christiaanb should give it a quick skim too in case I've missed something obvious (or worse, something subtle) |
DigitalBrains1
force-pushed
the
alterapll
branch
from
13a307c
to
1880545
Compare
DigitalBrains1
changed the title
alteraPll primitive
DigitalBrains1
force-pushed
the
alterapll
branch
from
1880545
to
dda0f63
Compare
Commit d325557 introduced an off-by-one error in the number of clocks to generate for 'alteraPll'. Additionally, the internal `locked` signal for `alteraPll` is changed to be of type `Bit` like in `altpll`. The borrowing of the type of the `Reset` input probably came about out of convenience back when resets were still a simple type so it did not matter. Now it looked odd but worked fine nonetheless. Also adjusted the type in `CondAssignment` in `altpll`, which showed the same pattern.
DigitalBrains1
force-pushed
the
alterapll
branch
from
dda0f63
to
9b10ae2
Compare
christiaanb
approved these changes
Mar 24, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
Commit d325557 introduced an off-by-one error in the number of clocks to generate for `alteraPll`. Additionally, the internal `locked` signal for `alteraPll` is changed to be of type `Bit` like in `altpll`. The borrowing of the type of the `Reset` input probably came about out of convenience back when resets were still a simple type so it did not matter. Now it looked odd but worked fine nonetheless. Also adjusted the type in `CondAssignment` in `altpll`, which showed the same pattern. (cherry picked from commit 9417cb6)
DigitalBrains1
added a commit
that referenced
this pull request
Mar 24, 2022
Commit d325557 introduced an off-by-one error in the number of clocks to generate for `alteraPll`. Additionally, the internal `locked` signal for `alteraPll` is changed to be of type `Bit` like in `altpll`. The borrowing of the type of the `Reset` input probably came about out of convenience back when resets were still a simple type so it did not matter. Now it looked odd but worked fine nonetheless. Also adjusted the type in `CondAssignment` in `altpll`, which showed the same pattern. (cherry picked from commit 9417cb6) Co-authored-by: Peter Lebbing <peter@digitalbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d325557 introduced an off-by-one error in the number of clocks
to generate for
alteraPll.Additionally, the internal
lockedsignal foralteraPllis changed tobe of type
Bitlike inaltpll. The borrowing of the type of theResetinput probably came about out of convenience back when resetswere still a simple type so it did not matter. Now it looked odd but
worked fine nonetheless.
Also adjusted the type in
CondAssignmentinaltpll, which showed thesame pattern.
Still TODO: