Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scanl1 to Clash prelude #2172

Merged
merged 1 commit into from
Apr 20, 2022
Merged

add scanl1 to Clash prelude #2172

merged 1 commit into from
Apr 20, 2022

Conversation

vmchale
Copy link
Contributor

@vmchale vmchale commented Apr 19, 2022

This adds scanl1 for vectors.

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

@vmchale
Copy link
Contributor Author

vmchale commented Apr 19, 2022

btw what should I tag this branch with so that it works correctly?

Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

changelog/2022-04-19T12_26_48-05_00_add_scanl1 Outdated Show resolved Hide resolved
clash-prelude/src/Clash/Sized/Vector.hs Outdated Show resolved Hide resolved
@martijnbastiaan
Copy link
Member

btw what should I tag this branch with so that it works correctly?

Everything should just work. But I think GitLab status reporting has been broken for a few days now, I'll look into it tomorrow morning. I think it's to do with the new-style GitHub tokens..

@martijnbastiaan
Copy link
Member

CI has been fixed; I've squashed all your commits to make a force push that triggers CI.

@martijnbastiaan martijnbastiaan enabled auto-merge (squash) April 20, 2022 07:44
@DigitalBrains1
Copy link
Member

We usually also add a GitHub PR link or issue link to the Changelog, but it doesn't seem to really add interesting information here, so I suppose it's not a problem that it is not there.

@martijnbastiaan
Copy link
Member

I wrote a script that acts like git blame, but instead it shows the PR. But yeah, would be handy-dandy if it was already in the changelog of course.

@martijnbastiaan martijnbastiaan merged commit 5928a2f into master Apr 20, 2022
@martijnbastiaan martijnbastiaan deleted the scan-prelude branch April 20, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants