Fix bit repr deriving for Records and Infix data types #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanG077
requested review from
christiaanb,
basile-henry,
alex-mckenna and
martijnbastiaan
and removed request for
basile-henry
rowanG077
force-pushed
the
fix-BitRepr-deriving
branch
2 times, most recently
from
bdc8d2b
to
4c635b8
Compare
using `Clash.Annotations.BitRepresentation.Deriving.deriveAnnotation`.
rowanG077
force-pushed
the
fix-BitRepr-deriving
branch
from
4c635b8
to
0f2a1b0
Compare
alex-mckenna
approved these changes
May 9, 2022
mergify bot
pushed a commit
that referenced
this pull request
May 12, 2022
using `Clash.Annotations.BitRepresentation.Deriving.deriveAnnotation`. (cherry picked from commit acf574a)
alex-mckenna
pushed a commit
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some missing constructors. GADT still aren't supported.
Still TODO:
I didn't update the copyright in the test files since it seems that test files don't have copyright notices.