Speed up, harmonize BitReduction #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DigitalBrains1
force-pushed
the
reducefuns
branch
from
32649b1
to
d06e778
Compare
|
Ooops, silly me. Hold on. |
DigitalBrains1
force-pushed
the
reducefuns
branch
from
d06e778
to
cbb65c9
Compare
|
Okay, now without dumb gaffes. |
martijnbastiaan
approved these changes
Jun 18, 2022
There was a problem hiding this comment.
Speed ups and harmonization LGTM.
With regards to the XException change: I think what you're doing here is correct. We've had reports before where people expected an undefined bitvector to have mask ~ maxBound instead of being a bottom. To me this makes sense, as the latter will break unjustifiably whenever an operation is applied to them. My opinion on it isn't very strong though.
The cases for `reduceAnd` and `reduceOr` where the mask is non-zero can also be sped up just like the cases with a zero mask. `reduceAnd` and `reduceOr` always produce a `Bit`, but possibly with a non-zero mask (i.e., an undefined value). `reduceXor` should also produce such a value, which is different from throwing an `XException` as it did.
DigitalBrains1
force-pushed
the
reducefuns
branch
from
cbb65c9
to
383837b
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 20, 2022
The cases for `reduceAnd` and `reduceOr` where the mask is non-zero can also be sped up just like the cases with a zero mask. `reduceAnd` and `reduceOr` always produce a `Bit`, but possibly with a non-zero mask (i.e., an undefined value). `reduceXor` should also produce such a value, which is different from throwing an `XException` as it did. (cherry picked from commit 99824af)
DigitalBrains1
added a commit
that referenced
this pull request
Jun 20, 2022
The cases for `reduceAnd` and `reduceOr` where the mask is non-zero can also be sped up just like the cases with a zero mask. `reduceAnd` and `reduceOr` always produce a `Bit`, but possibly with a non-zero mask (i.e., an undefined value). `reduceXor` should also produce such a value, which is different from throwing an `XException` as it did. (cherry picked from commit 99824af) Co-authored-by: Peter Lebbing <peter@digitalbrains.com>
vmchale
pushed a commit
that referenced
this pull request
Jun 23, 2022
The cases for `reduceAnd` and `reduceOr` where the mask is non-zero can also be sped up just like the cases with a zero mask. `reduceAnd` and `reduceOr` always produce a `Bit`, but possibly with a non-zero mask (i.e., an undefined value). `reduceXor` should also produce such a value, which is different from throwing an `XException` as it did.
vmchale
pushed a commit
that referenced
this pull request
Jun 27, 2022
The cases for `reduceAnd` and `reduceOr` where the mask is non-zero can also be sped up just like the cases with a zero mask. `reduceAnd` and `reduceOr` always produce a `Bit`, but possibly with a non-zero mask (i.e., an undefined value). `reduceXor` should also produce such a value, which is different from throwing an `XException` as it did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cases for
reduceAndandreduceOrwhere the mask is non-zero canalso be sped up just like the cases with a zero mask.
reduceAndandreduceOralways produce aBit, but possibly with anon-zero mask (i.e., an undefined value).
reduceXorshould alsoproduce such a value, which is different from throwing an
XExceptionas it did.
Still TODO: