Export Wrapping constructor #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbastiaan
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
LGTM, but please add a changelog entry :). See changelog/README.md for instructions. It's probably best to refer to #2292 too.
|
@adamwalker Do you still want this? |
|
Yes. I've added a changelog. |
|
Kloonbot errors with
so I think the problem is that @mergify rebase |
|
@mergify rebase |
This comment was marked as off-topic.
This comment was marked as off-topic.
✅ Branch has been successfully rebased |
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
(cherry picked from commit 031a664)
DigitalBrains1
pushed a commit
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2292
Is a changelog entry needed?