Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BiSignal tests look through Annotate #2475

Merged
merged 1 commit into from May 23, 2023
Merged

BiSignal tests look through Annotate #2475

merged 1 commit into from May 23, 2023

Conversation

christiaanb
Copy link
Member

Fixes #2472

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

@christiaanb christiaanb mentioned this pull request May 22, 2023
Closed
@christiaanb christiaanb force-pushed the fix_2472 branch 3 times, most recently from b25c29a to 89f5fcf Compare May 22, 2023 11:58
@DigitalBrains1
Copy link
Member

So does this also fix an independent issue with the size of the port not being rendered or does that only occur in this combination? Because if it's independent, I think it should have a changelog entry as well.

@christiaanb
Copy link
Member Author

It's independent. I'll add an additional entry.

@christiaanb christiaanb merged commit 1d70914 into master May 23, 2023
13 checks passed
@christiaanb christiaanb deleted the fix_2472 branch May 23, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DigitalBrains1 DigitalBrains1 DigitalBrains1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotate and BiSignal don't work together
2 participants
@christiaanb @DigitalBrains1