Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alteraPll qsys generation #2587

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix alteraPll qsys generation #2587

merged 1 commit into from
Oct 5, 2023

Conversation

DigitalBrains1
Copy link
Member

PR #2417 caused a bug in the generation of the qsys file: it generated a spurious extra output clock which was completely unused otherwise.

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

@DigitalBrains1
Fix alteraPll qsys generation
919db4e 
PR #2417 caused a bug in the generation of the `qsys` file: it generated
a spurious extra output clock which was completely unused otherwise.
@DigitalBrains1 DigitalBrains1 merged commit 5b055fb into master Oct 5, 2023
13 checks passed
@DigitalBrains1 DigitalBrains1 deleted the correct-qsys branch October 5, 2023 20:29
mergify bot pushed a commit that referenced this pull request Oct 5, 2023
@DigitalBrains1 @mergify
Fix alteraPll qsys generation (#2587)
9964e84 
PR #2417 caused a bug in the generation of the `qsys` file: it generated
a spurious extra output clock which was completely unused otherwise.

(cherry picked from commit 5b055fb)

# Conflicts:
#	clash-lib/src/Clash/Primitives/Intel/ClockGen.hs
@mergify mergify bot mentioned this pull request Oct 5, 2023
Merged
DigitalBrains1 added a commit that referenced this pull request Oct 6, 2023
@DigitalBrains1
Fix alteraPll qsys generation (#2587)
f2339ed 
PR #2417 caused a bug in the generation of the `qsys` file: it generated
a spurious extra output clock which was completely unused otherwise.

(cherry picked from commit 5b055fb)
DigitalBrains1 added a commit that referenced this pull request Oct 6, 2023
@mergify @DigitalBrains1
Fix alteraPll qsys generation (#2587) (#2588)
8d0d6be 
PR #2417 caused a bug in the generation of the `qsys` file: it generated
a spurious extra output clock which was completely unused otherwise.

(cherry picked from commit 5b055fb)

Co-authored-by: Peter Lebbing <peter@digitalbrains.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnbastiaan martijnbastiaan martijnbastiaan approved these changes

@christiaanb christiaanb Awaiting requested review from christiaanb

Assignees
No one assigned
Labels
backport 1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DigitalBrains1 @martijnbastiaan