Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WOFF OpenType fonts *should* work for all scripts #5

Closed
GoogleCodeExporter opened this issue Aug 9, 2015 · 3 comments
Closed

WOFF OpenType fonts *should* work for all scripts #5

GoogleCodeExporter opened this issue Aug 9, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link
Contributor

http://hacks.mozilla.org/2009/06/beautiful-fonts-with-font-face/

The Arabic example should download the OpenType font so it works with Harfbuzz. 
Instead, the ligatures still do not appear correctly.


Original issue reported on code.google.com by classi...@floodgap.com on 9 Nov 2010 at 4:50

@GoogleCodeExporter
Copy link
Contributor Author

Unfortunately, this message

http://www.mail-archive.com/harfbuzz@lists.freedesktop.org/msg00321.html

implies that Harfbuzz (as it is currently in Fx4) does not do ligatures either. 
However, I have altered gfx/thebes to ignore AAT fonts and prefer OpenType such 
that when/if Mozilla enables this support it will "just work." Marking Fixed on 
that basis and adding to TechnicalDifferences.

Original comment by classi...@floodgap.com on 20 Nov 2010 at 6:24

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Contributor Author

Hangul seems to be affected by this as of beta 8.

Original comment by classi...@floodgap.com on 5 Dec 2010 at 6:37

@GoogleCodeExporter
Copy link
Contributor Author

Review of font support:

- We are perfectly capable of rendering Hangul; there is an artificial 
limitation in gfxUnicodeProperties::ScriptShapingLevel() after beta 8 that 
turned it off. Hangul seems to render just fine, so that code has been blocked 
out and all scripts are allowed, even ones that Mozilla thinks won't work. This 
is wrong right now but will be right when Harfbuzz gets better. This also turns 
back on Hebrew.

- The OTS code requires us to set 
gfx.downloadable_fonts.sanitize.preserve_otl_tables to true for any advanced 
shaping, including the examples on

http://hacks.mozilla.org/2010/11/firefox-4-font-feature-support/

If we don't enable them, ligatures and other font features are absent. We don't 
use a platform shaper (we are all Harfbuzz), so we expose no attack surface 
this way that I can find. Setting the pref to true is now the default in beta 
8, but can be turned on in beta 7 (the consequences of which are not clear to 
me, so I am not recommending it).

With this pref on and the fixes above, plus the updated Harfbuzz in beta 8, the 
Arabic example at

http://people.mozilla.org/~jdaggett/demos/arabicfont.html

finally works, with correct ligatures. On that basis, Verified.

Original comment by classi...@floodgap.com on 6 Dec 2010 at 5:49

  • Changed state: Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant