WIP: Topotool updates #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems odd that this is failing like it is. Do we just need to update the tests? |
…t, same as read, rather than third, and 2) write with format 9.3f by default for smaller files, with new parameter Z_format to change. Also modified test problems for backward compatibility
…y rather than e.g. topo2writer, which should be deprecated, and changed output format for backward compatibility
…d by sampling every points, defaults to 1. Also allow filter_region=None to use entire region when coarsening.
rjleveque
force-pushed
the
topotool_updates
branch
from
a4b515c
to
20f3942
Compare
|
@mandli: Don't merge yet, I need to fix some things in topotools. By the way, the file |
… and fix maketopo.py to run same problem as regression_tests.py and fix out of date setplot.py
|
@mandli: I fixed up the regression tests that were broken here and travis is now happy, but I think there's a potential problem with the way gauge tests are done to be addressed at some point. See clawpack/clawutil#101. I changed the default |
|
This all looks good to me. Is this ready to be merged then? |
|
Yes, I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some change in default behavior of
Topography.writethat should be examined.Enhancement of
Topography.cropto support coarsening a topo grid as well.Several Travis tests currently fail, also on master, so we need to sort this out before merging.