make netcdf build on travis #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having some issues with netcdf in our build of clawpack and I realized that we have actually never been testing netcdf on travis. Previously, the netcdf tests would pass if netcdf-based builds failed. At some point, I changed this behavior to "Skip" but since that point, all travis builds have skipped. I installed the appropriate netcdf libraries and now that test is passing "for real".
I also bumped the python 3.x version to 3.7. We could test on 3.5 (and any other 3.x) as well if you think its useful?
Finally, I just added the macOS .DS_Store file to the gitignore since it was annoying me.