-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weno_order solver keyword argument is silently ignored when kernel_language='Python' #242
Comments
This is pretty simple to reproduce:
On my machine I see the following output:
The Python error aligns with the default weno order=5:
|
If you're raising this as an issue, there are a dozen other combinations to raise. This was never designed as a real API. The point of the apps/ directory is to give simple examples. If you wanted to check for all these things, you'd need to make all the scripts twice as long (definitely a bad idea) or add new code implementing a standardized API for the apps scripts (probably a bad thing, in my opinion, since it makes it seem more complicated for users to roll their own scripts). |
To amend my last comment, after looking more closely: I agree that the solver should tell you something is wrong if you set solver.weno_order != 5 and solver.kernel_language='Python'. Or we should go in and call the PyWENO kernels. |
We should either raise an error when this occurs or fix it.
The text was updated successfully, but these errors were encountered: