Raise exception when weno_order!=5 and kernel_language==Python. #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be an exception rather than just a logger warning or does this happen later on? |
|
I guess it's a philosophical question -- should we warn the user and then proceed with the next best thing, or fail because we can't do exactly what was requested. Probably the latter, I guess. If you agree, I will change it to raise an exception. |
|
Since there is a chance that the user might not see the warning it probably is best to raise an exception and allow them to correct the problem. |
ketch
force-pushed
the
warn_python_weno
branch
from
9ac32e0
to
c558fc8
Compare
ketch
changed the title
|
Okay, I changed it to an exception. Will merge after tests pass. |
mandli
added a commit
that referenced
this pull request
Aug 26, 2014
Raise exception when weno_order!=5 and kernel_language==Python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #242.