-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Euler 3D examples with a test #444
Conversation
Example script for the 3D Euler equations with dimensional splitting. This example solves a 1D shocktube problem in a 3D domain.
This is an example script for the 3D Euler equations with dimensional splitting. A fully 3D Sedov blast problem is solved.
Made formatting changes to make code more readable. Added an argument to switch between split and unsplit methods, so that this example can be used with the rpt3_euler.f90 and rptt3_euler.f90 files that were recently edited.
Modified code to make it more readable.
* master: Add Travis badge to README. Add coverage badge to README. Update README.md Change path for logging configuration Remove petclaw's log.config file First attempt to use coveralls.io. hdf5 reader working (barely). More description of test parameters. Modify acoustics 2d variable test to be shorter Make psystem_2d tests run faster by using shorter time and smaller grid. Make 3D acoustics tests run faster by using smaller grid. Update version of hashdist that we rely on. Eliminate q_or_aux variable. Fix clawpack#426 (writing aux with PETSc leads to empty q file).
Initial Sedov problem with cell averages.
Looks good to me. I would only say make sure the test does not take more than a couple of seconds. |
* master: Clean up some of the code and add more doc-strings Add normal CLI to quadrants example Update CHANGES.md for 5.2.0. Fix HashDist to 0.3 tag Correct solution.read docstring Conflicts: src/pyclaw/solution.py
Currently the new test is skipped on Travis, since it requires scipy and h5py. But it runs and passes on my machine. I'd like to merge this with the understanding that we'll add scipy to our Travis stack as soon as we have a binary install from hashdist. Then this test will be enabled on Travis. In the meantime, developers should be running tests locally too, especially since the tests are now fast. |
This all looks fine with me. Do you want to add an issue to remind us to re-enable the test or just include it in the issue for the SciPy stack travis problem? |
I added a comment to the Scipy Travis stack issue. |
This is work by @weslowrie (see #430, which this replaces). It includes:
I made one important change to the Sedov problem setup: it now initializes using cell averages, rather than just checking whether the cell center is inside the initial radius.