Euler 3D examples with a test #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example script for the 3D Euler equations with dimensional splitting. This example solves a 1D shocktube problem in a 3D domain.
This is an example script for the 3D Euler equations with dimensional splitting. A fully 3D Sedov blast problem is solved.
Made formatting changes to make code more readable. Added an argument to switch between split and unsplit methods, so that this example can be used with the rpt3_euler.f90 and rptt3_euler.f90 files that were recently edited.
Modified code to make it more readable.
* master: Add Travis badge to README. Add coverage badge to README. Update README.md Change path for logging configuration Remove petclaw's log.config file First attempt to use coveralls.io. hdf5 reader working (barely). More description of test parameters. Modify acoustics 2d variable test to be shorter Make psystem_2d tests run faster by using shorter time and smaller grid. Make 3D acoustics tests run faster by using smaller grid. Update version of hashdist that we rely on. Eliminate q_or_aux variable. Fix clawpack#426 (writing aux with PETSc leads to empty q file).
Initial Sedov problem with cell averages.
|
Looks good to me. I would only say make sure the test does not take more than a couple of seconds. |
* master: Clean up some of the code and add more doc-strings Add normal CLI to quadrants example Update CHANGES.md for 5.2.0. Fix HashDist to 0.3 tag Correct solution.read docstring Conflicts: src/pyclaw/solution.py
|
Currently the new test is skipped on Travis, since it requires scipy and h5py. But it runs and passes on my machine. I'd like to merge this with the understanding that we'll add scipy to our Travis stack as soon as we have a binary install from hashdist. Then this test will be enabled on Travis. In the meantime, developers should be running tests locally too, especially since the tests are now fast. |
|
This all looks fine with me. Do you want to add an issue to remind us to re-enable the test or just include it in the issue for the SciPy stack travis problem? |
|
I added a comment to the Scipy Travis stack issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work by @weslowrie (see #430, which this replaces). It includes:
I made one important change to the Sedov problem setup: it now initializes using cell averages, rather than just checking whether the cell center is inside the initial radius.