-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example scripts for the 3D Euler equations. #430
Conversation
Example script for the 3D Euler equations with dimensional splitting. This example solves a 1D shocktube problem in a 3D domain.
This is an example script for the 3D Euler equations with dimensional splitting. A fully 3D Sedov blast problem is solved.
Thanks for the help @weslowrie, I think this looks pretty good but I think if you adding some spaces around some things PEP 8 style-wise it would lead to a more readable code, especially the function arguments as there are quite a few of those and the binary operators in some places. Also, line continuations We should also add a significantly shortened version of these to the testing at some point. |
Good to know about the PEP 8 style spec. I'll make some modifications to improve the styling. |
@weslowrie thanks! |
Made formatting changes to make code more readable. Added an argument to switch between split and unsplit methods, so that this example can be used with the rpt3_euler.f90 and rptt3_euler.f90 files that were recently edited.
Modified code to make it more readable.
Changes Unknown when pulling 5c0472a on weslowrie:master into * on clawpack:master*. |
Changes Unknown when pulling 5c0472a on weslowrie:master into * on clawpack:master*. |
Does the coverage status mean the code needs to be simplified? |
This is replaced by #444, which includes a test. |
Hi,
I'm submitting a couple sample scripts for the 3D Euler equations. A simple 1D shocktube in a 3D domain, and a Sedov type blast problem in a fully 3D domain.
Hope they are helpful.