Some cleanup in state.py. #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you broke something with PETSc: It kind of looks like you renamed the local vec, is there somewhere that should have changed as well? |
| @q.setter | ||
| def q(self,val): | ||
| num_eqn = val.shape[0] | ||
| if self.gqVec is None: self._init_q_da(num_eqn) |
There was a problem hiding this comment.
This line might be the source of problems.
|
Ahh, no, I think lqVec is used somewhere else as Kyle mentioned. |
|
Yeah, I messed up a merge when I rebased this (very old) work. Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.