Refactor toplevel #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maojrs
pushed a commit
to maojrs/riemann
that referenced
this pull request
Mar 19, 2015
Improved conversion scripts and added some fvmbook examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the top level refactoring of clawpack. riemann will now reside as part of clawpack as
clawpack.riemannand be available to easy_install/pip from a single:easy_install numpy && easy_install clawpack
or
pip install numpy && pip install clawpack.
The riemann package currently does not possess any of its own tests, but it appears to be functioning for its pyclaw uses. The top-level setup.py is not used by the top-level clawpack installer and is likely to be removed unless somebody needs it for something.
You can test this (in concert with the patches to clawpack) by installing virtualenv, creating a new virtual environment, then running:
pip install numpy && pip install -e
"git+https://github.com/ahmadia/clawpack.git@refactor_toplevel#egg=clawpack"
Note that if you are using EPD on OS X you will need the development version of virtualenv.