[WIP] Adds Point-Wise Versions of the Riemann Solvers #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the initial version of the wrapper harness for point-wise Riemann solver and an example of the scalar advection and acoustics point-wise Riemann solver implementations.
Includes PyClaw build support and an acoustics example Riemann solver.
|
This is great. During the workshop new developers could easily take on the task of porting more solvers to the pointwise format and running some timing comparisons. |
|
clawpack/pyclaw#473 is dependent on this, and presumably that's why it's failing. I guess we need to merge this and then do a commit to clawpack/clawpack so that that one will pass. |
ketch
added a commit
that referenced
this pull request
Nov 6, 2014
[WIP] Adds Point-Wise Versions of the Riemann Solvers
|
@mandli I merged this but now I'm not sure if you meant for it to be merged yet. Since it is working and fully backward-compatible, I figured it would be good to have a functioning prototype that people at the workshop can easily use/build on next week. Having it in master means one less obstacle. |
|
I think it's fine, as you said it was meant to be safe and all the tests were passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.