Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop pointwise Riemann solvers #87

Closed
ketch opened this issue Nov 4, 2014 · 4 comments
Closed

Develop pointwise Riemann solvers #87

ketch opened this issue Nov 4, 2014 · 4 comments

Comments

@ketch
Copy link
Member

ketch commented Nov 4, 2014

Description

@mandli
Copy link
Member

mandli commented Nov 5, 2014

It would be nice if in the transverse point-wise solvers we included not only the row above and below of the aux array (as is done now) but also of the q array. This would not be backwards compatible with the implementation suggested as only a row of q is passed to the rpt routines.

@ketch ketch added this to the 5.3.0 milestone Nov 5, 2014
@mandli
Copy link
Member

mandli commented Nov 5, 2014

Another issue with using rp* as the wrapper is that to get the interface above to work a temporary array must be created to store the correct values of aux1, aux2 and aux3 in aux_l and aux_r. This could be avoided again if the point-wise solver was called one level up in for instance flux2.

@mandli
Copy link
Member

mandli commented Nov 9, 2014

May want to let the window of the cells passed to both the normal and transverse solvers (not just the local ones).

@ketch
Copy link
Member Author

ketch commented Mar 19, 2015

Closed via #91.

@ketch ketch closed this as completed Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants