Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cStringIO deprecated in Python 3 #200

Closed
rjleveque opened this issue Feb 9, 2017 · 2 comments
Closed

cStringIO deprecated in Python 3 #200

rjleveque opened this issue Feb 9, 2017 · 2 comments
Assignees

Comments

@rjleveque
Copy link
Member

src/python/visclaw/JSAnimation/html_writer.py uses cStringIO, which has been deprecated in Python 3, see e.g. http://stackoverflow.com/questions/28200366/python-3-4-0-email-package-install-importerror-no-module-named-cstringio

@ketch: I think we dealt with this someplace else in Clawpack already with a good way to deal with the different versions, but I can't remember where now...

@ketch
Copy link
Member

ketch commented Feb 9, 2017

This is more difficult than I expected. I have a version that runs here:

https://github.com/ketch/visclaw/blob/python3_html_writer/src/python/visclaw/JSAnimation/html_writer.py

However, the animation images and the control icons just show up as broken links, so this is useless so far.

@ketch
Copy link
Member

ketch commented Feb 24, 2019

This got fixed in 3f9b25a. Closing.

@ketch ketch closed this as completed Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants