Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow components API within a sub-directory #119

Closed
cruzanmo opened this issue Aug 5, 2015 · 7 comments
Closed

Allow components API within a sub-directory #119

cruzanmo opened this issue Aug 5, 2015 · 7 comments
Labels

Comments

@cruzanmo
Copy link

cruzanmo commented Aug 5, 2015

e.g. http://qa.nymag.com/components/article/instances/pr-first.html is broken.

Can we allow for http://qa.nymag.com/press/components/article/instances/pr-first.html

Related to #118

@cruzanmo cruzanmo added the bug label Aug 5, 2015
@cruzanmo
Copy link
Author

cruzanmo commented Aug 5, 2015

Could maybe resolve with a nginx rewrite rule?

A global config might make sense, so you could set the host and path in a global config and then each site's config could overwrite it.

@TakenPilot TakenPilot added feature and removed bug labels Aug 5, 2015
@cruzanmo
Copy link
Author

cruzanmo commented Aug 5, 2015

Bug: github leaves the bug label on even though it shows Dane removed the bug label.

@TakenPilot
Copy link
Contributor

Components are not site-specific. Sites are applied to the router after components are added, because they need to be higher priority in express's list of routes.

If a site wants components at a subpath, they could create another instance of byline for that particular site. Then it would get the functionality that you're asking for, and also get site specific components.

@nelsonpecora
Copy link
Contributor

This is not a byline issue, but rather an issue with the QA env

@TakenPilot
Copy link
Contributor

Yeah, that's why I put the enhancement label on this. The route works, but not in his particular environment. The suggestion of:

Can we allow for http://qa.nymag.com/press/components/article/instances/pr-first.html

Related to #118

means that he wants to have data with two different URIs (very anti-REST; the RI means Resource Identifier, so having two of them refer to the same data breaks the idea, especially when they start writing to one or the other), or he wants to have a new place to save data specific to that site.

@yoshokatana @cruzanmo

@nelsonpecora
Copy link
Contributor

Agreed. From our discussion yesterday, I think the best way to go might be the separate buckets.

@TakenPilot
Copy link
Contributor

This is now available as of v0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants