Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - Support Underscored Routes #47

Closed
pfeytser opened this issue Feb 5, 2018 · 3 comments
Closed

CLI - Support Underscored Routes #47

pfeytser opened this issue Feb 5, 2018 · 3 comments
Assignees

Comments

@pfeytser
Copy link

pfeytser commented Feb 5, 2018

No description provided.

@nelsonpecora
Copy link
Contributor

The fix for this is:

  • use underscored routes by default
  • add a --amphora-version <integer> flag
  • if the amphora version is set to 4 (or lower), use non-underscored routes

(note: we're doing this, rather than a binary --no-underscored-routes flag, because the amphora api might change in future versions. this way, we'll be able to use claycli with multiple amphora versions without having to checkout different claycli versions, which is a hassle)

@nelsonpecora
Copy link
Contributor

Actually, we'd need to split it into two flags anyway (it's possible to import from an old version of amphora to a new version), and this is a common enough use case that it should be fast to write. Thus, we should do:

  • --amphora-legacy, -a use non-underscored api routes (applies like --key)
  • --source-amphora-legacy, -A use non-underscored api routes (applies like --source-key)

@nelsonpecora
Copy link
Contributor

We're actually going to handle this dynamically, but for now I've made a major version of claycli with hardcoded underscore support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants