Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #1

Closed
halbmy opened this issue Sep 28, 2017 · 2 comments
Closed

Python 3 compatibility #1

halbmy opened this issue Sep 28, 2017 · 2 comments

Comments

@halbmy
Copy link

halbmy commented Sep 28, 2017

Dear Charles,
great work that can be of value for many SIP people! Thanks for sharing it.
I noticed that it only works for Python 2 (I guess only 2.7 as the pyd is linked against it). However, after long years of coexistence of Python 2 and Python 3, the days of Python 2 are over and all distributions are moving to Python 3 only as planned many years ago. So did we, not distributing any 2.7 stuff anymore.

Making the code compatible with both Python 2 and 3 should be easy using the future module (http://python-future.org) or 2to3 tools. I would appreciate it and I am sure it would increase users a lot.
Thomas

@clberube
Copy link
Owner

Dear Thomas,
I totally agree. I will work on making it compatible in both Python 2 and 3.
Charles

@clberube
Copy link
Owner

clberube commented Oct 3, 2017

Hello Thomas,
It is now compatible with Python 3. I've been testing it for the past few days on the latest Anaconda distribution with Python 3.6.2 without problems. I also added support for quick installation through pip. That should solve the problem with the pyd since it should now build on your machine.
I refer you to the readme and Jupyter notebooks if you would like to see some examples.

Keep in mind this code was initially designed in my free time to help the SIP colleagues at our University since there was no code publicly available then. It is not always practical. Also due to the stochastic nature of the algorithm it is more designed for learning about the data or models than for big production. However, the way its written I think makes it easy to use and easily integrable with other codes so maybe someone out there will find it useful.
I try not to spend too much time on this now if I want to graduate in 2018... but it is a fun project and I will keep updating from time to time.

@clberube clberube closed this as completed Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants