Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashed and dotted are broken #22

Open
szukw000 opened this issue Aug 4, 2016 · 7 comments
Open

dashed and dotted are broken #22

szukw000 opened this issue Aug 4, 2016 · 7 comments

Comments

@szukw000
Copy link

szukw000 commented Aug 4, 2016

I use fifth-0.5 and webkitfltk-0.5.1. Both borders below are broken.
Which file in webkitfltk-0.5.1 draws border lines resp. border styles?

winfried

10px red dashed
Column 1 Column 2
Aaa Aaa Aaa Xxx Xxx Xxx
Bbb Bbb Bbb Yyy Yyy Yyy
Ccc Ccc Ccc Zzz Zzz Zzz
10px blue dotted
Column 1 Column 2
Aaa Aaa Aaa Xxx Xxx Xxx
Bbb Bbb Bbb Yyy Yyy Yyy
Ccc Ccc Ccc Zzz Zzz Zzz
@clbr
Copy link
Owner

clbr commented Aug 4, 2016

Rendered result: http://imgur.com/tSfiu5h

This is handled entirely by the common webkit code, and so should either affect all webkit browsers or all webkit browsers using cairo. I can't tell offhand which files are involved.

@szukw000
Copy link
Author

I compiled webkitgtk-2.13.4 and found that 'bin/MiniBrowser' does show the borders
correctly.

Now I compiled 'surf2' using webkitgtk. It dows show the borders correctly.

Both programs are assumed to use CAIRO.

winfried
surf2-borders

@szukw000
Copy link
Author

@clbr,
how does this look like? I have changed the file

Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp

winfried
dot-dash

@szukw000
Copy link
Author

@clbr , here is the patch.

winfried

GraphicsContextCairo.cpp.dif.zip

@clbr
Copy link
Owner

clbr commented Aug 29, 2016

This looks like a partial backport with different function name, etc. It would cause code conflicts the next time I sync against upstream webkit.

If it's indeed solved in current webkit, then I'd prefer for larger things like this to happen with the sync. If you need a source with that patch, I'd advise you to make a fork here on github. I can't give a date for when I can do the update, as it takes all day, not sure when I have that much free.

@szukw000
Copy link
Author

szukw000 commented Sep 1, 2016

@clbr ,
I do not understand your objections.

The library compiles without error, the result is OK. What do you want more?

winfried

@clbr
Copy link
Owner

clbr commented Sep 1, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants