-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue "Codepage broken in Russian version of radeontop" #73
base: master
Are you sure you want to change the base?
Conversation
The setlocale call is made in radeontop.c, and the Makefile change would break the build on some systems, so I can't accept this change. What's your distro if the pkg-config call fails? |
Can you pass this correction to the maintainer ubuntu? I do not know how to do it correctly. |
"What's your distro if the pkg-config call fails?" |
What happens if you run this:
|
-lncursesw -ltinfo |
I'm sorry, I forgot to say: libncursesw5-dev is required to success compile. |
Your output means your Makefile change was not needed. Now that you installed the correct dev package, does radeontop work without any changes? |
Yes, it works! |
That already happens in radeontop.c. Please try to find out why, calling it twice should not be necessary. |
I do not know how to do that. But make no complains about twice setlocale(). |
I tried to remove setlocale(LC_ALL, "") from radeontop.c and add to ui.c. |
https://raw.githubusercontent.com/wb027/radeontop/master/screenshots/radeontop_ru_utf-8_fixed.png
Compiled & tested on Linux Mint 19 (ubuntu 18.04 based).