Handling ssid scanning exception

[clburlison]

It's unclear if this is just a bug on 10.13 but I've managed to get airport command to give bad data multiple times tonight. This might be due to the very active wifi area that I'm in but Apple shouldn't give an incomplete file. 😞

pinpoint/pkgroot/Library/Application Support/pinpoint/bin/pinpoint

Lines 538 to 540 in feaafc6

	# TODO (clburlison): This can error with
	# FoundationPlist.FoundationPlist.NSPropertyListSerializationException: Encountered unexpected EOF # noqa
	ssid_scan = FoundationPlist.readPlistFromString(ssid_scan)

[danner26]

This happened to me many times. On campus, we will have machines that cannot report data because printer wifi networks cause issues (the stupid HP DIRECT wifi signals). Not sure if some have carriage returns or something, but during the airport scan the xml fetched will quit halfway.

[clburlison]

So this issue is just to track the hard crash. pinpoint should read the exception and write out an error.

I'm pretty sure it isn't a carriage return issue simply the airport command not being written in a way that it can handle that many SSIDs. I was able to replicate this a few times without pinpoint by calling:

/System/Library/PrivateFrameworks/Apple80211.framework/Versions/A/Resources/airport -s --xml 

It does look like I can replace the airport subprocess call with code from the Core WLAN framework. https://developer.apple.com/documentation/corewlan/cwinterface?language=objc That however it going to take a bit of time to write up and test.

[clburlison]

Switching to CoreWLAN is going to be the better solution. I have a mock up working so I'll switch to that in the next release.