New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omnisearch can refuse to do string searches if there are a few integers mixed in #102

Closed

cldellow opened this issue Mar 4, 2023 · 0 comments

Owner

cldellow commented Mar 4, 2023

SQLite's squishy typing kinda bites us here.

datasette-ui-extras/datasette_ui_extras/omnisearch.py

Line 85 in 57a0448

    
           elif column['texts'] + column['nulls'] == column['count'] and column['texts_newline'] == 0 and not dateish(column):

tries to only do autosuggest for things containing string values

In practical use, this seems a bit strict. Let's be willing to do autosgugest in omnisearch as long as 90% of the contents are strings.

cldellow closed this as completed in

1fa2287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment