-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-15062 Export generateJsProps #316
Conversation
Security Insights(5) Vulnerable direct dependencies were detectedbrowserslist < 4.16.5 via yarn.lock elliptic < 6.5.4 via yarn.lock glob-parent < 5.1.2 via yarn.lock lodash < 4.17.21 via yarn.lock ssri < 6.0.2 via yarn.lock Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Public API ChangesRecommendation: @@ line 112: package:react/src/react_client/factory_util.dart @@
+ JsMap generateJsProps(Map<dynamic, dynamic> props, {bool convertRefValue = true, bool convertCallbackRefValue = true, List<String> additionalRefPropKeys = const [], bool wrapWithJsify = true})
// Adding a top-level function is a minor change. Showing results for feac624
Last edited UTC Aug 02 at 19:38:59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
+10 (stable CI passing)
@Workiva/release-management-pp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
generateJsProps
is used inReactComponentFactoryProxy
classes to constructReact.createElement
-compatible JS props objects from Dart props Maps, and includes conversion of refs and optional deep jsifiation of nested objects.React.createElement
is the primary recipient of these kinds of JS props objects, but there are cases in which consumers may need to pass those props to other JS recipients.For example, you may want to call a JS callback with those props, or even opt to perform conversion of props before they get to the
ReactComponentFactoryProxy
.Solution
generateJsProps
as a public APIUnrelated changes
Testing Steps
N/A (CI passes)