Consolidate OVMF.fd versions

[gtkramer]

What is the issue type?

• Bug report
• Enhancement request

Describe the problem

There are three different versions and multiple copies of OVMF.fd that are published in various locations:

• The copy on https://download.clearlinux.org/image/OVMF.fd .
• The copy in https://github.com/clearlinux/how-to-clear/blob/master/files/qemu/OVMF.fd
• The copy installed by the edk2 package in /usr/share/qemu/OVMF.fd this version includes secureboot EFI features
• The copy in https://github.com/clearlinux/common

There should be one version from which people use that is updated in all places.

[phmccarty]

Just to clarify, the OVMF.fd in the current edk2 package is identical to the one from https://github.com/clearlinux/common. But you're right that there are three different copies.

I agree that consolidation is needed.

[ahkok]

$ curl -L https://download.clearlinux.org/image/OVMF.fd | sha512sum 
c080ad4f019874a27838dfb4530ed59a85f910e0697620e8a5cc681eed0f3b987f17c34d665687b60340e2ff8c89c7e436a67d27618c9a252479e535fb8f6b10  -
$ curl -L https://github.com/clearlinux/common/raw/master/OVMF.fd | sha512sum 
fb7ed078471ef3190fb288768201262e9fbba5f0b620fc98d11456a97bc096d805f6ec597ca43cea1aea37f41ab45d31ca43209fde9f8dbecc9440c5b93c096f  -
$ sha512sum /usr/share/qemu/OVMF.fd 
fb7ed078471ef3190fb288768201262e9fbba5f0b620fc98d11456a97bc096d805f6ec597ca43cea1aea37f41ab45d31ca43209fde9f8dbecc9440c5b93c096f  /usr/share/qemu/OVMF.fd
$ curl -L https://github.com/clearlinux/how-to-clear/raw/master/files/qemu/OVMF.fd | sha512sum 
206e27017b8f8ef197e498130d2262c51c5e1d1b8ab1d69e57eba393aa026efbba19e5e14dfc51fa6f17487bc380af94b88a53e1395b29afcbd2f0e5b1b45f1f  -

[ahkok]

I can push an update into how-to-clear, but I'd like to know for sure first, which is the right one?!

[gtkramer]

I think we should be using the one distributed in Clear from the edk2 package. A couple of folks have expressed interest in updating the external copy of OVMF.fd on download.clearlinux.org with the one from in Clear as well.

[chamings]

While y'all are deciding what to do with this, I'd like to point out a problem with the current firmware image: it does not detect any nvdimm devices assigned by qemu. I haven't tried with actual hardware yet, but an emulated device backed by file or memory does not show up inside the guest when booted with any of the above OVMF.fd - but it will show up with legacy boot (and an Ubuntu 18 guest).

(How to do this with qemu: https://github.com/qemu/qemu/blob/master/docs/nvdimm.txt)

[DnPlas]

Based on a previous discussion with @bryteise, all OVMF.fd versions should be the same. I can push updates for the mismatching files.
Maybe we should think about how to ease the maintenance as well, @gtkramer.

[gtkramer]

@chamings, thank you for pointing this out! Good to know. Please file a separate issue for this.