Copy of Making repeated state publication optional #595 #42
Conversation
There was a problem hiding this comment.
I reviewed this while looking at the changes in https://github.com/cra-ros-pkg/robot_localization/pull/595/files and apart from the permit_corrected_publication ROS parameter and permitCorrectedPublication_ attribute, that you seem to have dropped from this PR, all looks fine and it's the same.
Maybe you could have cherry-picked the upstream commit, but I guess you already tried and that didn't work, so this is fine.
| @@ -648,6 +648,10 @@ template<class T> class RosFilter | |||
| //! | |||
| geometry_msgs::TransformStamped worldBaseLinkTransMsg_; | |||
|
|
|||
| //! @brief The time of the most recent published state | |||
There was a problem hiding this comment.
In https://github.com/cra-ros-pkg/robot_localization/pull/595/files the permit_corrected_publication ROS parameter and permitCorrectedPublication_ variables were created. Did you miss that part, or you simply don't want that part?
There was a problem hiding this comment.
I just left it out since I don't think we would ever use those params and I was trying to keep it as minimal as possible.
I think we need to sync fully with upstream at some point so we can reintegrate properly then.
Yes I tried to cherry pick it and it was massive conflicts not sure why but I didn't want to deal with it. |
Since we have diverged from upstream rather significantly at this point I was not able to simply cherry pick this change without major conflicts, so I just copied it.
Original change: cra-ros-pkg#595
We should properly sync our fork with upstream at some point.