Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipit-panel additions #45

Closed
cleebp opened this issue Mar 1, 2016 · 6 comments
Closed

Clipit-panel additions #45

cleebp opened this issue Mar 1, 2016 · 6 comments

Comments

@cleebp
Copy link
Owner

cleebp commented Mar 1, 2016

Hey all,

I'm fiddling with Effat's clipit-panel today and just wanted to log what I'm trying out, if we don't like the changes we can always revert my changes, just thought I'd try to make the interaction a little more seamless!

I'll just post on this issue what I'm trying out...

  1. I have made it so that when you copy an item it immediately shows up on the panel, rather than showing up only after hitting the paste command (note for items copied outside of atom they will only show up on the panel after you paste them into atom)
@cleebp
Copy link
Owner Author

cleebp commented Mar 1, 2016

  1. Working on making the paste command also just paste the most recent item into the editor (work in progress, harder than it should be)
  2. Might look at fiddling with the panel .css

@arjunmadan
Copy link
Collaborator

Okay, I'll integrate telemetry once you're done. I can probably do it before, but should probably try and avoid those pesky merge conflicts if possible. xD

@cleebp
Copy link
Owner Author

cleebp commented Mar 1, 2016

Sounds good, anything else you think I should look at tweaking for the panel's features?

@cleebp
Copy link
Owner Author

cleebp commented Mar 1, 2016

  1. Working on making the paste command also just paste the most recent item into the editor (work in progress, harder than it should be)

This is now implemented in my most recent commit, new goal:

  • Fix behavior after clicking an item in the panel having to "reset" the panel back to the view

@cleebp
Copy link
Owner Author

cleebp commented Mar 1, 2016

Fix behavior after clicking an item in the panel having to "reset" the panel back to the view

Fixed, took awhile to figure out how to do this haha.

Probably taking a break for now, I think the panel is in a good place, I wish I understood the way it displays better and how panels work to make it the full height of the panel, which would help with scrolling through items. But I think its definitely demo-able now!

@cleebp
Copy link
Owner Author

cleebp commented Mar 1, 2016

Gonna close this issue since we are theoretically done editing clipit-panel before the demo.

@cleebp cleebp closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants