Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvment to avoid rollback #21

Closed
ghost opened this issue Oct 15, 2016 · 8 comments
Closed

Possible improvment to avoid rollback #21

ghost opened this issue Oct 15, 2016 · 8 comments

Comments

@ghost
Copy link

ghost commented Oct 15, 2016

Rollback are prevented secondary (if DPoS fails) by the amount of PoW for each block.

The node doesn't approve fork with a shorter chain but (maybe) ATM the wallet check only if the current block count is lower or higher than the one proposed by the fork.

Instead of count only the total number of blocks, shouldn't be more safe, count the block for each account?

Ex:

(now)

A: 5tx
B: 10tx

proposed fork

A: 5tx
B: 5tx
C: 20tx

The fork pass

(with the improvment)

A: 5tx
B: 10tx

proposed fork

A: 5tx
B: 5tx
C: 20tx

The fork doesn't pass because the fork propose shorter chain for account A and B

@clemahieu
Copy link
Contributor

An attacker can generate attacks with
longer chains: publishing a long chain generated offline
shorter chains: publishing a shorter chain generated offline

The DPoS can't fail: I think the theoretical basis for RaiBlocks is fine, there must be a bug in the implementation or too few bootstrap nodes that caused the rollbacks.

@SergiySW
Copy link
Contributor

SergiySW commented Nov 9, 2016

So, how many nodes do we need for network stability and to prevent rollbacks (if this is the cause)?

@ghost
Copy link
Author

ghost commented Nov 9, 2016

@clemahieu follow only longer chain should be a fine security measure.

@SergiySW more nodes, more stability, but we need to set more representative too.

Here you can check all rep atm: https://raiblockscommunity.net/page/representatives.php

@HostFat
Copy link
Contributor

HostFat commented Nov 9, 2016

@clemahieu please find some little time to come back at your great product :)

Also raiblocks.net is offline now.

@ghost
Copy link
Author

ghost commented Nov 9, 2016

@HostFat the website is online, the ssl is out of date. The node itself is offline.

@HostFat
Copy link
Contributor

HostFat commented Nov 9, 2016

Ah yes, I saw it now. :)

@ghost
Copy link
Author

ghost commented Nov 9, 2016

@clemahieu Yes, @HostFat , please make RaiBlocks "Great again" ;D

@clemahieu
Copy link
Contributor

Rollback should be fixed with 7.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants