Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization of cam_coords in inverse_warp #49

Closed
plaut opened this issue Jan 15, 2019 · 1 comment
Closed

Normalization of cam_coords in inverse_warp #49

plaut opened this issue Jan 15, 2019 · 1 comment

Comments

@plaut
Copy link

plaut commented Jan 15, 2019

Shouldn't cam_coords be normalized by its L2 norm before multiplying by the depth?
i.e., add:
cam_coords /= torch.norm(cam_coords, p=2, dim=1, keepdim=True)
before this line:

return cam_coords * depth.unsqueeze(1)

@ClementPinard
Copy link
Owner

depth is not distance to the camera ! It's actually the z coordinate, hence the third point coordinate set to 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants