Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Keystrokes are doubled #1065

Closed
1 task done
brian6932 opened this issue Mar 14, 2023 · 4 comments · Fixed by #1066
Closed
1 task done

[Bug] Keystrokes are doubled #1065

brian6932 opened this issue Mar 14, 2023 · 4 comments · Fixed by #1066
Labels
bug Something isn't working the way that is expected.

Comments

@brian6932
Copy link

brian6932 commented Mar 14, 2023

Checklist

Describe the issue

All keystrokes are doubled (sent twice), most noticeable when using /

What operating system and version are you using?

Windows 10

What architecture are you using?

x86_64 / AMD64

What terminal(s) are you running bottom on?

alacritty 0.11.0 (d23330a)

What version of bottom are you running?

bottom 0.8.1-nightly-61fec230

How did you install bottom?

Personal scoop package in scoop/versions, uses latest successful artifact

How can we reproduce this?

No particular steps taken, I just launched the most recent nightly ver

Additional information

config

[flags]
group_processes = true
regex = true
mem_as_value = true
@brian6932 brian6932 added the bug Something isn't working the way that is expected. label Mar 14, 2023
@ClementTsang
Copy link
Owner

Interesting, I can reproduce this. Let me bisect and see where this is coming up, as I didn't have issues on my Windows 11 environment not too long ago.

@ClementTsang
Copy link
Owner

ClementTsang commented Mar 14, 2023

Well that was easy to guess, bumping the crossterm version in commit f02bd21 was the problem.

Will either revert and/or see what I messed up and try to get that out ASAP.

@ClementTsang
Copy link
Owner

Was taking a look in the changelogs - I think it's maybe this:

Add key release event for windows.

For now I'll just revert crossterm to solve the issue, which seems to work for me.

@ClementTsang
Copy link
Owner

Merged revert, should hopefully work for you now. Nightly build will be out at the usual time in a few hours if you don't mind waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way that is expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants