USR-135 fix(clerk-js): Address spacing issues when password feedback message changes #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d2bba46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
raptisj
force-pushed
the
jr/password_changes
branch
from
0544510
to
13efcea
Compare
raptisj
force-pushed
the
jr/password_changes
branch
2 times, most recently
from
f94096f
to
c49ae69
Compare
panteliselef
previously requested changes
Jul 14, 2023
raptisj
force-pushed
the
jr/password_changes
branch
from
c49ae69
to
745d6f8
Compare
raptisj
force-pushed
the
jr/password_changes
branch
from
de0e94f
to
a3ee6ff
Compare
desiprisg
reviewed
Jul 17, 2023
desiprisg
reviewed
Jul 17, 2023
raptisj
changed the title
raptisj
force-pushed
the
jr/password_changes
branch
from
515cc9f
to
4acb798
Compare
…address spacing issues fix(clerk-js): Add changeset
fix(clerk-js): Fix falling tests fix(clerk-js): Fix falling tests fix(clerk-js): Minor refactor / change changeset summary fix(clerk-js): Minor refactor
fix(clerk-js): Move addFullStop helper in generateErrorTextUtil fix(clerk-js): Revert adding addFullStop helper in generateErrorTextUtil
fix(clerk-js): Simplify addFullStop helper
raptisj
force-pushed
the
jr/password_changes
branch
from
4acb798
to
d2bba46
Compare
|
Did we lose the animations here? I can see they're missing in the before as well? @panteliselef Am I missing something? |
desiprisg
approved these changes
Jul 19, 2023
Merged
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(clerk-js): Add changeset
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Before:
Screen.Recording.2023-07-12.at.6.40.34.PM.mov
After:
Screen.Recording.2023-07-12.at.6.43.58.PM.mov