Can continue craft (and craft*) without theoretical knowledge

[Brambor]

Describe the bug

If you have an unfinished craft, you can continue crafting it. Regardless of your theoretical knowledge. This shouldn't be possible.

Attach save file

TEST hint good-trimmed.tar.gz

Steps to reproduce

Can craft without knowledge:

• You cannot do it just by selecting it in the Crafting GUI, there is a "frontend" check. You have to recraft, which is impossible without debugging, I think.

1. Set PC skill theoretical to all 10
2. craft a recipe (like makeshift metal arrow)
3. Set PC skill to all 0 (theoretical and practical)
4. recraft the last recipe -
5. The PC just does it.

The player is able to continue a craft without the skills required:

You can obtain the craft in different ways:

1. debug set skills to 10, start craft, debug set skills to 0
2. Have another character craft it, then continue crafting it (basegame)

You can continue the crafting in at least two ways:

1. activating the item

   Cataclysm-DDA/src/iexamine.cpp

   Line 7292 in d30757e

   if( !you.has_recipe( &rec, inv, you.get_crafting_group() ) ) {

2. from a workbench interface

   Cataclysm-DDA/src/iuse.cpp

   Line 8351 in d30757e

   if( !p->has_recipe( &rec, inv, p->get_crafting_group() ) ) {

Expected behavior

I need theoretical knowledge to make complex recipes. Even if somebody starts the craft, I cannot continue the craft.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.4291 (22H2)
• Game Version: 0.G-8890-gd30757ea5f [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth]
  ]

Additional context

I originally outlined it in my review of my #73103.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.