Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No displayed binding for "Display keybindings menu" #73423

Closed
dennmar opened this issue May 1, 2024 · 1 comment
Closed

No displayed binding for "Display keybindings menu" #73423

dennmar opened this issue May 1, 2024 · 1 comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@dennmar
Copy link

dennmar commented May 1, 2024

Describe the bug

In the keybindings menu, there is no displayed binding for “Display keybindings menu”.

Attach save file

N/A

Steps to reproduce

  1. Navigate to Settings at the title screen using the right arrow key (→).
  2. Press the down arrow key (↓) to highlight Keybindings.
  3. Press the enter key to open the keybindings menu.
  4. Press the down arrow key (↓) until a line starting with “Display keybindings menu” appears in the keybindings menu (but there’s no corresponding binding displayed).
  5. If you’ve previously customized the binding for “Display keybindings menu”, then reset the binding by pressing “*” and then pressing the key displayed to the left of “Display keybindings menu”. After that, “Display keybindings menu” will have no corresponding binding.

Expected behavior

The keybindings menu should display a “?” for the binding for “Display keybindings menu”.

Screenshots

No binding displayed for "Display keybindings menu" in the keybindings menu (zoomed in):
NoBindingForDisplayKeybindingsMenu

First message of tutorial displays ' ' instead of '?':
NoBindingTutorialText

Unknown command help text will correctly display "?" (no bug here - just additional information):
UnknownCommandHelp

Attempt to bind "?" to another action will correctly ask for confirmation (no bug here - just additional information):
AttemptToRebindQuestionMark

Versions and configuration

OS: Ubuntu 20.04 (with WSL and Windows 11)
Game Version: a60d305
Graphics Version: Terminal
In-game Language: English

Additional context

In the first message of the tutorial, it displays ' ' instead of ‘?' to open the keybindings menu. The unknown command help at the bottom right will correctly display “?” when talking about seeing and editing keybindings. Trying to add “?” as a global binding to another action correctly prompts for confirmation, since that keybinding will be removed from “Display keybindings menu”. Also, “?” brings up the keybindings menu and “?” is set as the key for HELP_KEYBINDINGS in data/raw/keybindings.json.

Removing the “?” keybinding for “Display keybindings menu” and changing it to something else like “F5” fixes all the above issues. After changing the keybinding, it is correctly displayed as “F5” in the keybindings menu, first message of the tutorial, and unknown command help in the bottom right.

@dennmar dennmar added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label May 1, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label May 31, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

1 participant