Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Magiclysm] - Asking Seer to reveal an Orc Village leads to a Goblin Outpost with the mission "Visit the Orcs" #73433

Closed
AcidAntOnAMinefield opened this issue May 1, 2024 · 2 comments · Fixed by #73791
Closed

[Magiclysm] - Asking Seer to reveal an Orc Village leads to a Goblin Outpost with the mission "Visit the Orcs" #73433

AcidAntOnAMinefield opened this issue May 1, 2024 · 2 comments · Fixed by #73791
Labels
Good First Issue This is a good first issue for a new contributor Mods: Magiclysm Anything to do with the Magiclysm mod (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@AcidAntOnAMinefield
Copy link

Describe the bug

As title says.

Talking to the seer, it sends the player to a Goblin Outpost (Green "G") instead of a place where Orcs would be. I saw no Orcs there, but killed many a Warg and many a Goblins.

Attach save file

N/A

Steps to reproduce

  1. Start a World with Magiclysm
  2. Visit Forge of Wanders
  3. Talk to Seer
  4. Ask for Orcs.
  5. Get Goblins instead.
  6. Wonder why "orcs = Goblins".

Expected behavior

I would expect to get Orcs.

Screenshots

No response

Versions and configuration

Version: Linux 5d07beb

mods:

dda
magiclysm
bombastic_perks

Additional context

No response
@AcidAntOnAMinefield AcidAntOnAMinefield added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label May 1, 2024
@Standing-Storm
Copy link
Contributor

This is a result of #71758 -- I didn't realize there was Forge of Wonders dialogue that needed to be updated.

@AcidAntOnAMinefield
Copy link
Author

This is a result of #71758 -- I didn't realize there was Forge of Wonders dialogue that needed to be updated.

Huh.

Tbh quite disappointing to learn that Orcs are just mutated Goblins - imo that makes no sense, as they are different species entirely.

@Maleclypse Maleclypse added Good First Issue This is a good first issue for a new contributor (S2 - Confirmed) Bug that's been confirmed to exist Mods: Magiclysm Anything to do with the Magiclysm mod and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels May 9, 2024
TheAthenaCabin0 added a commit to TheAthenaCabin0/Cataclysm-DDA that referenced this issue May 14, 2024
@TheAthenaCabin0
Update diviner missions and dialogue options
f6f8f1a 
There were repeats of mission options in places that didn't make sense,
and mission dialogue and the mission-giving related to the orcs needed
to be updated with the overhaul to goblins and orcs. With that, her
characterization was made more consistent through her dialogue, and an
rng roll was added to allow both wizard tower missions to be
independently assigned, albeit randomly.
fixes CleverRaven#73433, references CleverRaven#71758
@TheAthenaCabin0 TheAthenaCabin0 mentioned this issue May 14, 2024
Merged
Maleclypse added a commit that referenced this issue May 20, 2024
@TheAthenaCabin0 @Maleclypse @github-actions
[Magiclysm] Update Forge of Wonders Dialogue Options (#73791)
f1c803e 
* Update diviner missions and dialogue options
There were repeats of mission options in places that didn't make sense,
and mission dialogue and the mission-giving related to the orcs needed
to be updated with the overhaul to goblins and orcs. With that, her
characterization was made more consistent through her dialogue, and an
rng roll was added to allow both wizard tower missions to be
independently assigned, albeit randomly.
fixes #73433, references #71758

* Add interval dialogue to Forge Merchants
None of the merchants in the Forge of Wonders previously had a dialogue
option to update the player when their next restock should be, a QOL
feature that was painfully missing.
references #73434

* Update data/mods/Magiclysm/npc/TALK_FORGE_DIVINER.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update data/mods/Magiclysm/npc/TALK_FORGE_MERCHANT.json

* Apply suggestions from code review

* Apply suggestions from code review

* Update data/mods/Magiclysm/npc/TALK_FORGE_HELEN_TAVREL.json

---------

Co-authored-by: Maleclypse <54345792+Maleclypse@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue This is a good first issue for a new contributor Mods: Magiclysm Anything to do with the Magiclysm mod (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Magiclysm] Update Forge of Wonders Dialogue Options TheAthenaCabin0/Cataclysm-DDA
3 participants
@Maleclypse @AcidAntOnAMinefield @Standing-Storm