Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classic_zombies unintentionally removes all map extras #74578

Closed
shadowonwhite opened this issue Jun 16, 2024 · 1 comment · Fixed by #74603
Closed

classic_zombies unintentionally removes all map extras #74578

shadowonwhite opened this issue Jun 16, 2024 · 1 comment · Fixed by #74603
Labels
Good First Issue This is a good first issue for a new contributor Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@shadowonwhite
Copy link
Contributor

shadowonwhite commented Jun 16, 2024

Describe the bug

{
"type": "region_overlay",
"regions": [ "all" ],
"overmap_feature_flag_settings": { "whitelist": [ "CLASSIC" ] }
},

This seems to require map extras to have the tags too, which none does.

Attach save file

N/A

Steps to reproduce

1.Create world with classic_zombies enabled
2.Try to find a single map extra

Expected behavior

do not check map extras for tags

Screenshots

No response

Versions and configuration

OS: Windows
OS Version: 10.0.19045.4529 (22H2)
Game Version: 9568831 [64-bit]
Graphics Version: Tiles
Game Language: System language []
Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
Slowdown Fungal Growth [no_fungal_growth],
Translate Complex Dialogue [translate_dialogue],
sees-player, run, crouch, bleed icons, retrodays [sees_player_retro],
SpeedyDex [speedydex],
Stats Through Skills [StatsThroughSkills],
Bionic Slots [cbm_slots]

Additional context

Deleting the aforementioned line and reloading the save fixes the problem.

@shadowonwhite shadowonwhite added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jun 16, 2024
@Procyonae
Copy link
Contributor

Procyonae commented Jun 16, 2024

Adding the flags where appropriate makes sense in this case, it can either be done in vanilla like it currently does or in the mod itself like I did here when adding a whitelist to Backrooms. (Which personally I feel should be the norm)

{
"id": "mx_casings",
"type": "map_extra",
"copy-from": "mx_casings",
"extend": { "flags": [ "BACKROOMS" ] }
},

I would also like the whitelist/blacklist flags to be split by type/subtype in region settings bc this makes using whitelists kind of annoying depending what you want but that's a seperate issue

@Procyonae Procyonae added Good First Issue This is a good first issue for a new contributor (S2 - Confirmed) Bug that's been confirmed to exist Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a good first issue for a new contributor Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants