fix: normalize hostname for auth login

[tuananhlai]

Fixes #6979

Normalize hostname before write to config file / login.

vscode ➜ /workspaces/cli (fix/normalize-hostname-login) $ go run cmd/gh/main.go auth login -h GitHub.com -p https
? Authenticate Git with your GitHub credentials? Yes
? How would you like to authenticate GitHub CLI? Login with a web browser

! First copy your one-time code: 4293-8C48
Press Enter to open github.com in your browser... 
✓ Authentication complete.
- gh config set -h github.com git_protocol https
✓ Configured git protocol
✓ Logged in as tuananhlai

vscode ➜ /workspaces/cli (fix/normalize-hostname-login) $ go run cmd/gh/main.go auth status
github.com
  ✓ Logged in to github.com as tuananhlai (/home/vscode/.config/gh/hosts.yml)
  ✓ Git operations for github.com configured to use https protocol.
  ✓ Token: gho_************************************
  ✓ Token scopes: gist, read:org, repo, workflow

vscode ➜ /workspaces/cli (fix/normalize-hostname-login) $ cat ~/.config/gh/hosts.yml 
github.com:
    user: tuananhlai
    oauth_token: <oauth_token>
    git_protocol: https

[mislav]

Hi, thank you for attempting to fix this, but I would rather see that the original cause of the bug was addressed and discovered.

For example, it should be valid to do gh auth login -h GITHUB.COM and have the whole authentication flow complete and the token getting stored under GITHUB.COM. We should be matching hostnames case-insensitively throughout the codebase without having to normalize hostnames at the time of logging in and storing tokens.

I would appreciate if the bug fix was a change that was applied to the part of the codebase where the error that was originally reported comes from. Thank you!

[tuananhlai]

How should the app handle if the user is already logged in to github.com, then reauthenticate with GitHub.com? Should we save both of them in hosts.yml? 🤔

[tuananhlai]

Furthermore, the cause of the bug in #6979 is because cfg.AuthToken(hostname) method normalized the hostname internally. If we want to store and validate the user-input hostname, we'd have to modify this method.

https://github.com/cli/cli/blob/trunk/pkg/cmd/auth/status/status.go#L94

[mislav]

Good point about the cfg.AuthToken method. I have looked up how that works and saw that the fixes would have to be applied to our external library (go-gh). I've proposed some changes there: cli/go-gh#105

If we decide to go that route and the go-gh change gets merged, there will be no need for this PR, as the issue will be solved. However, I thank you for proposing to fix this in the first place. Let's first see what happens with the other PR; I will update this thread accordingly.

[mislav]

Resurrecting this fix because the underlying fix in the go-gh library proved to be more trouble than it's worth.