Print message after codespace deletion

[kousikmitra]

Fixes #7348

Deleted one codepsace

❯❯ ./bin/gh cs delete                                                                                                     
? Choose codespace: kousikmitra/cli (trunk): legendary lamp
✓ Successfully deleted kousikmitra-legendary-lamp-wr5xpggpr442gvq

Note: Printing name of the codespace here as I think it would be more helpful for subsequent commands.

Deleted multiple codespace

❯❯ ./bin/gh cs delete --all                                                                                               
✓ Successfully deleted 2 codespaces

Edit:

partial success

❯❯ ./bin/gh cs delete --all                                                                            
Deleting codespaces ⡿error deleting codespace "kousikmitra-silver-bassoon-xyz": dummy error for testing
1 codespace(s) deleted successfully
1 codespace(s) failed to delete

all failed

❯❯ ./bin/gh cs delete --all                                                                            
Deleting codespaces ⡿error deleting codespace "kousikmitra-urban-sniffle-abc": dummy error for testing
error deleting codespace "kousikmitra-fluffy-spoon-xyz": dummy error for testing
2 codespace(s) failed to delete

all success

❯❯ ./bin/gh cs delete --all                                                                            
2 codespace(s) deleted successfully

❯❯ ./bin/gh cs delete --all                                                                            
1 codespace(s) deleted successfully

[jkeech]

Thanks for making this change! It looks like a good improvement to me, but I left a suggestion for changing the wording in a partial-success case with some deletions succeeding and some failing.

[cmbrose]

@kousikmitra thanks for this! Could you also include a sample of what the output looks like if 1 or more codespaces fail to delete? (You might have to hack in a fake error to get that)

[kousikmitra]

@kousikmitra thanks for this! Could you also include a sample of what the output looks like if 1 or more codespaces fail to delete? (You might have to hack in a fake error to get that)

@cmbrose here!

err := a.apiClient.DeleteCodespace(ctx, codespaceName, opts.orgName, opts.userName)
if idx == 1 && err == nil {
    err = fmt.Errorf("dummy error for testing")
}
if err != nil {
    a.errLogger.Printf("error deleting codespace %q: %v\n", codespaceName, err)
    return err
}

Output

❯❯ ./bin/gh cs delete --all                                                                                      
Deleting codespaces ⡿error deleting codespace "kousikmitra-ominous-disco-r46wqpp59452xvjv": dummy error for testing
✓ Successfully deleted 1 codespaces
some codespaces failed to delete

[Asomakn]

                    wantStderr:  "1 codespace(s) deleted successfully\n",