Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shellcheck errors in generate.sh #7392

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

cmbrose
Copy link
Contributor

@cmbrose cmbrose commented May 1, 2023

Fixes: #7382

Fixes shellcheck errors reported in generate.sh by the above issue. The only proto changes are because the protobuf version bumped

@cmbrose cmbrose requested a review from a team as a code owner May 1, 2023 14:59
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label May 1, 2023
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI May 1, 2023
@cmbrose cmbrose requested a review from dmgardiner25 May 1, 2023 15:08
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 May 1, 2023
@cmbrose cmbrose merged commit 443bb75 into trunk May 1, 2023
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 May 1, 2023
@cmbrose cmbrose deleted the cmbrose/shellcheck-bugs branch May 1, 2023 15:31
renovate bot added a commit to scottames/dots that referenced this pull request May 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [aquaproj/aqua-registry](https://togithub.com/aquaproj/aqua-registry)
| minor | `v4.1.0` -> `v4.3.0` |
| [charmbracelet/glow](https://togithub.com/charmbracelet/glow) | patch
| `v1.5.0` -> `v1.5.1` |
| [cli/cli](https://togithub.com/cli/cli) | minor | `v2.28.0` ->
`v2.29.0` |
| [fluxcd/flux2](https://togithub.com/fluxcd/flux2) | patch |
`v2.0.0-rc.1` -> `v2.0.0-rc.2` |
| [helm/helm](https://togithub.com/helm/helm) | minor | `v3.11.3` ->
`v3.12.0` |
|
[kubernetes-sigs/kustomize](https://togithub.com/kubernetes-sigs/kustomize)
| patch | `v5.0.2` -> `v5.0.3` |

---

### Release Notes

<details>
<summary>aquaproj/aqua-registry</summary>

###
[`v4.3.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.3.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.2.0...v4.3.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.3.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.3.0)
| aquaproj/aqua-registry@v4.2.0...v4.3.0

#### 🎉 New Packages


[#&#8203;12034](https://togithub.com/aquaproj/aqua-registry/issues/12034)
[boyter/scc](https://togithub.com/boyter/scc): Sloc, Cloc and Code: scc
is a very fast accurate code counter with complexity calculations and
COCOMO estimates written in pure Go
[@&#8203;ponkio-o](https://togithub.com/ponkio-o)

#### Fixes


[#&#8203;12073](https://togithub.com/aquaproj/aqua-registry/issues/12073)
WebAssembly/binaryen: Regenerate settings by `aqua-registry scaffold
--deep`

[#&#8203;12088](https://togithub.com/aquaproj/aqua-registry/issues/12088)
charmbracelet/glow: Follow up changes of glow v1.5.1

###
[`v4.2.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.2.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.1.0...v4.2.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.2.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.2.0)
| aquaproj/aqua-registry@v4.1.0...v4.2.0

#### 🎉 New Packages


[#&#8203;12000](https://togithub.com/aquaproj/aqua-registry/issues/12000)
[ikanago/omekasy](https://togithub.com/ikanago/omekasy): Command line
application that converts alphanumeric characters to various styles
defined in Unicode [@&#8203;4513ECHO](https://togithub.com/4513ECHO)

[#&#8203;11999](https://togithub.com/aquaproj/aqua-registry/issues/11999)
[marwan-at-work/mod](https://togithub.com/marwan-at-work/mod): Automated
Semantic Import Versioning Upgrades

[#&#8203;11998](https://togithub.com/aquaproj/aqua-registry/issues/11998)
[oligot/go-mod-upgrade](https://togithub.com/oligot/go-mod-upgrade):
Update outdated Go dependencies interactively

#### Fixes


[#&#8203;12021](https://togithub.com/aquaproj/aqua-registry/issues/12021)
derailed/k9s: Follow up changes of k9s v0.27.4

-   https://github.com/derailed/k9s/releases/tag/v0.27.4
-
[derailed/k9s#1971


[#&#8203;12023](https://togithub.com/aquaproj/aqua-registry/issues/12023)
bep/s3deploy: follow up changes of s3deploy v2.9.0

https://github.com/bep/s3deploy/releases/tag/v2.9.0

> We have ported the release script to Hugoreleaser. This means that the
archive names have changed (standardised), but it also means that you
get only one unviversal, notarized MacOS PKG archive.

</details>

<details>
<summary>charmbracelet/glow</summary>

###
[`v1.5.1`](https://togithub.com/charmbracelet/glow/releases/tag/v1.5.1)

[Compare
Source](https://togithub.com/charmbracelet/glow/compare/v1.5.0...v1.5.1)

#### What's Changed

- fix: rm emoji from package description by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[charmbracelet/glow#453
- fix: improve editor handling by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[charmbracelet/glow#449
- fix: do not use deprecated func by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[charmbracelet/glow#451
- docs: fix typos by [@&#8203;kianmeng](https://togithub.com/kianmeng)
in
[charmbracelet/glow#471
- chore(deps): bump actions/setup-go from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[charmbracelet/glow#478
- fix: lazily init UI by [@&#8203;muesli](https://togithub.com/muesli)
in
[charmbracelet/glow#494

***

<a href="https://charm.sh/"><img alt="The Charm logo"
src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a>

Thoughts? Questions? We love hearing from you. Feel free to reach out on
[Twitter](https://twitter.com/charmcli), [The
Fediverse](https://mastodon.technology/@&#8203;charm), or on
[Discord](https://charm.sh/chat).

</details>

<details>
<summary>cli/cli</summary>

### [`v2.29.0`](https://togithub.com/cli/cli/releases/tag/v2.29.0):
GitHub CLI 2.29.0

[Compare Source](https://togithub.com/cli/cli/compare/v2.28.0...v2.29.0)

#### What's New

- Add `alias import` command by
[@&#8203;kevhlee](https://togithub.com/kevhlee) in
[cli/cli#7118
- `codespace`: Add capability to filter by `--repo-owner` by
[@&#8203;kousikmitra](https://togithub.com/kousikmitra) in
[cli/cli#7347
- `pr status`: display auto-merge information by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[cli/cli#7386
- `pr view`: display auto-merge information by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[cli/cli#7385
- `pr`: add `autoMergeRequest` field to JSON output by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[cli/cli#7384

#### What's Changed

- `repo create`: fix empty default description for local repository by
[@&#8203;vwkd](https://togithub.com/vwkd) in
[cli/cli#7383
- `release download`: show progress bar by
[@&#8203;joshkraft](https://togithub.com/joshkraft) in
[cli/cli#7380
- `codespace delete`: print confirmation message by
[@&#8203;kousikmitra](https://togithub.com/kousikmitra) in
[cli/cli#7353
- Fix shellcheck errors in generate.sh by
[@&#8203;cmbrose](https://togithub.com/cmbrose) in
[cli/cli#7392
- New deployment workflow for releases by
[@&#8203;mislav](https://togithub.com/mislav) in
[cli/cli#7324
- `make install`: fix for macOS by
[@&#8203;Xerkus](https://togithub.com/Xerkus) in
[cli/cli#7369

#### New Contributors

- [@&#8203;vwkd](https://togithub.com/vwkd) made their first
contribution in
[cli/cli#7383

**Full Changelog**: cli/cli@v2.28.0...v2.29.0

</details>

<details>
<summary>fluxcd/flux2</summary>

###
[`v2.0.0-rc.2`](https://togithub.com/fluxcd/flux2/releases/tag/v2.0.0-rc.2)

[Compare
Source](https://togithub.com/fluxcd/flux2/compare/v2.0.0-rc.1...v2.0.0-rc.2)

#### Highlights

This is the 2nd release candidate of Flux v2.0 GA. Users are advised to
upgrade from `v0.41` to `v2.0.0-rc.2` as soon as possible.

Flux v2.0.0-rc.2 comes with fixes to issues reported for RC.1 and
performance improvements. Starting with this version, source-controller,
kustomize-controller and helm-controller pods are marked as
[system-cluster-critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/).
This priority class will reduce the chances of Flux controllers being
evicted before other non-critical workloads and prevents the pods from
being permanently unavailable.

:bulb: For upgrading from v0.x, please see [the procedure documented in
RC.1](https://togithub.com/fluxcd/flux2/releases/tag/v2.0.0-rc.1).

:warning: Note that Kubernetes 1.27.0 contains a regression bug that
affects Flux, it is recommended to upgrade Kubernetes to 1.27.1 or
newer.

##### Fixes and improvements

-   Fix bootstrap for BitBucket Server (CLI).
- Fix secrets decryption when using Azure Key Vault
(kustomize-controller).
-   Fix drift detection for renamed HelmReleases (helm-controller).
- Improve performance when handling webhook receivers
(notification-controller).
- The `Alert` v1beta2 API has a new optional field `.spec.inclusionList`
for fine-grained control over events filtering
(notification-controller).
- The deprecated field `.status.url` was removed from the `Receiver` v1
API (notification-controller).
- Add support for commit signing using OpenPGP keys with passphrases
(image-automation-controller).

#### Components changelog

- source-controller
[v1.0.0-rc.2](https://togithub.com/fluxcd/source-controller/blob/v1.0.0-rc.2/CHANGELOG.md)
- kustomize-controller
[v1.0.0-rc.2](https://togithub.com/fluxcd/kustomize-controller/blob/v1.0.0-rc.2/CHANGELOG.md)
- notification-controller
[v1.0.0-rc.2](https://togithub.com/fluxcd/notification-controller/blob/v1.0.0-rc.2/CHANGELOG.md)
- helm-controller
[v0.32.2](https://togithub.com/fluxcd/helm-controller/blob/v0.32.2/CHANGELOG.md)
- image-reflector-controller
[v0.27.1](https://togithub.com/fluxcd/image-reflector-controller/blob/v0.27.1/CHANGELOG.md)
- image-automation-controller
[v0.33.0](https://togithub.com/fluxcd/image-automation-controller/blob/v0.33.0/CHANGELOG.md)

#### CLI Changelog

- PR [#&#8203;3860](https://togithub.com/fluxcd/flux2/issues/3860) -
[@&#8203;bigkevmcd](https://togithub.com/bigkevmcd) - e2e: Add summary
to Azure Alert
- PR [#&#8203;3858](https://togithub.com/fluxcd/flux2/issues/3858) -
[@&#8203;fluxcdbot](https://togithub.com/fluxcdbot) - Update toolkit
components
- PR [#&#8203;3857](https://togithub.com/fluxcd/flux2/issues/3857) -
[@&#8203;talife](https://togithub.com/talife) - Fix autocompletion for
image repository reconcile
- PR [#&#8203;3855](https://togithub.com/fluxcd/flux2/issues/3855) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump peter-evans/create-pull-request from 5.0.0 to 5.0.1
- PR [#&#8203;3854](https://togithub.com/fluxcd/flux2/issues/3854) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump github/codeql-action from 2.3.2 to 2.3.3
- PR [#&#8203;3853](https://togithub.com/fluxcd/flux2/issues/3853) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump anchore/sbom-action from 0.14.1 to 0.14.2
- PR [#&#8203;3849](https://togithub.com/fluxcd/flux2/issues/3849) -
[@&#8203;makkes](https://togithub.com/makkes) - Update
fluxcd/go-git-providers to v0.15.3
- PR [#&#8203;3838](https://togithub.com/fluxcd/flux2/issues/3838) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump github/codeql-action from 2.3.0 to 2.3.2
- PR [#&#8203;3837](https://togithub.com/fluxcd/flux2/issues/3837) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump sigstore/cosign-installer from 3.0.2 to 3.0.3
- PR [#&#8203;3833](https://togithub.com/fluxcd/flux2/issues/3833) -
[@&#8203;matheuscscp](https://togithub.com/matheuscscp) - Add OCI
provider option to create Helm source command
- PR [#&#8203;3830](https://togithub.com/fluxcd/flux2/issues/3830) -
[@&#8203;cuishuang](https://togithub.com/cuishuang) - misc: fix some
comments
- PR [#&#8203;3827](https://togithub.com/fluxcd/flux2/issues/3827) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump github/codeql-action from 2.2.12 to 2.3.0
- PR [#&#8203;3822](https://togithub.com/fluxcd/flux2/issues/3822) -
[@&#8203;Hey](https://togithub.com/Hey) - Fix outdated Loki Helm values
URL
- PR [#&#8203;3821](https://togithub.com/fluxcd/flux2/issues/3821) -
[@&#8203;makkes](https://togithub.com/makkes) - Fix bootstrap for
Bitbucket Server
- PR [#&#8203;3805](https://togithub.com/fluxcd/flux2/issues/3805) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump github/codeql-action from 2.2.11 to 2.2.12
- PR [#&#8203;3804](https://togithub.com/fluxcd/flux2/issues/3804) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump actions/checkout from 3.5.0 to 3.5.2
- PR [#&#8203;3802](https://togithub.com/fluxcd/flux2/issues/3802) -
[@&#8203;stefanprodan](https://togithub.com/stefanprodan) - Set priority
class for the critical Flux components
- PR [#&#8203;3797](https://togithub.com/fluxcd/flux2/issues/3797) -
[@&#8203;makkes](https://togithub.com/makkes) - better messaging for
`pull artifact` command
- PR [#&#8203;3796](https://togithub.com/fluxcd/flux2/issues/3796) -
[@&#8203;fluxcdbot](https://togithub.com/fluxcdbot) - Update
helm-controller to v0.32.2
- PR [#&#8203;3795](https://togithub.com/fluxcd/flux2/issues/3795) -
[@&#8203;stefanprodan](https://togithub.com/stefanprodan) - Run
conformance tests for Kubernetes 1.27
- PR [#&#8203;3783](https://togithub.com/fluxcd/flux2/issues/3783) -
[@&#8203;aryan9600](https://togithub.com/aryan9600) - Clean directory
before cloning git repo
- PR [#&#8203;3780](https://togithub.com/fluxcd/flux2/issues/3780) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump github/codeql-action from 2.2.9 to 2.2.11
- PR [#&#8203;3779](https://togithub.com/fluxcd/flux2/issues/3779) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump peter-evans/create-pull-request from 4.2.4 to 5.0.0
- PR [#&#8203;3778](https://togithub.com/fluxcd/flux2/issues/3778) -
[@&#8203;dependabot](https://togithub.com/dependabot)\[bot] -
build(deps): bump sigstore/cosign-installer from 3.0.1 to 3.0.2
- PR [#&#8203;3768](https://togithub.com/fluxcd/flux2/issues/3768) -
[@&#8203;relu](https://togithub.com/relu) - Fix publishing pre-release
versions to AUR
- PR [#&#8203;3764](https://togithub.com/fluxcd/flux2/issues/3764) -
[@&#8203;somtochiama](https://togithub.com/somtochiama) - Add label
selector flag to get cmd

</details>

<details>
<summary>helm/helm</summary>

###
[`v3.12.0`](https://togithub.com/helm/helm/compare/v3.11.3...v3.12.0)

[Compare
Source](https://togithub.com/helm/helm/compare/v3.11.3...v3.12.0)

</details>

<details>
<summary>kubernetes-sigs/kustomize</summary>

###
[`v5.0.3`](https://togithub.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.0.3)

[Compare
Source](https://togithub.com/kubernetes-sigs/kustomize/compare/kustomize/v5.0.2...kustomize/v5.0.3)

This release reverts the regression with the helm plugin that was
introduced in v5.0.2.

Built with go 1.19.9 to remove CVE vulnerabilities.

##### Changelog


[kubernetes-sigs/kustomize#5164:
Revert "Fix using same helm chart with different versions"

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/scottames/dots).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43NC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtpetty pushed a commit that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external pull request originating outside of the CLI core team
Projects
No open projects
The GitHub CLI
  
Pending Release 🥚
Development

Successfully merging this pull request may close these issues.

generate.sh: bugs identified by shellcheck
3 participants