-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix executable location #8238
Fix executable location #8238
Conversation
Hi @samcoe, This issue seems to be slightly more complicated than expected. While writing the tests, I realized that the result of That is, we're going to make these changes: Lines 65 to 72 in 6ffd882
cli/pkg/cmdutil/factory_test.go Lines 12 to 19 in 6ffd882
|
It's a little late today in my time zone. I'll keep working on this as soon as I have time. |
Hi @samcoe, I've changed the code and written tests. Please help to review these changes, thanks! |
It seems that the relative path symbolic links required for testing on macOS are not the same as those required on Windows or Linux, which is a bit confusing for me. cli/pkg/cmdutil/factory_test.go Lines 32 to 36 in 6ffd882
It may be related to this issue golang/go#30520. |
I have created a simple demo and managed to reproduce the issue. It could be caused by the In another test, I found that in macOS,
|
This issue pertains to the functioning of |
@xqm32 Thanks for the continued effort here. Before going further I wonder if you could clarify your original issue. You mentioned #5982 earlier, that issue does not seem related to these proposed changes? Did you link to the wrong issue? Additionally, I know we have other WSL2 and Homebrew users and we have not received any issues since #5428 has something changed with WSL2 or Homebrew since then? |
Oops, my bad! It's #5428, not #5928. Sorry for the confusion!
I'm not aware of any changes to WSL2 or Homebrew since issue #5428. However, I've noticed in my WSL2 setup that Homebrew is now using relative paths instead of absolute ones. Also, Homebrew on my Mac is using relative paths. However, I don't use GitHub CLI to set up Git on my Mac, so I'm unsure if the same issue exists there. > readlink $(which go)
../Cellar/go/1.21.4/bin/go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xqm32 I proposed some changes here. I think they solve the problem and also avoid the hacking we had to do in the tests. I tested this out locally and am fairly confident in it. Could you test it locally to see if it solves your use case? If it does, I think we can revert the current test changes and then write a new test that is similar to Test_executable
except using relative symlinks.
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
@samcoe I committed your changes and rewrote the tests, tested it locally and it does work. Please help to review these changes, thanks! The following is the commands I used for testing: make bin/gh
ln -s bin/gh gh
./bin/gh auth setup-git
cat ~/.gitconfig
export PATH="$(pwd):${PATH}"
./bin/gh auth setup-git
cat ~/.gitconfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xqm32 Thanks for the hard work on this! I think it is ready to ship 👍
[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://togithub.com/aquaproj/aqua-registry) | minor | `v4.82.0` -> `v4.88.0` | | [bitnami-labs/sealed-secrets](https://togithub.com/bitnami-labs/sealed-secrets) | patch | `v0.24.3` -> `v0.24.4` | | [cli/cli](https://togithub.com/cli/cli) | minor | `v2.38.0` -> `v2.39.1` | | [derailed/k9s](https://togithub.com/derailed/k9s) | patch | `v0.28.0` -> `v0.28.2` | | [junegunn/fzf](https://togithub.com/junegunn/fzf) | minor | `0.43.0` -> `0.44.1` | | [kevincobain2000/gobrew](https://togithub.com/kevincobain2000/gobrew) | patch | `v1.9.6` -> `v1.9.9` | | [kubernetes/kubectl](https://togithub.com/kubernetes/kubectl) | patch | `1.28.3` -> `1.28.4` | | [nektos/act](https://togithub.com/nektos/act) | patch | `v0.2.53` -> `v0.2.54` | | [simulot/immich-go](https://togithub.com/simulot/immich-go) | patch | `0.8.1` -> `0.8.3` | | [stern/stern](https://togithub.com/stern/stern) | minor | `v1.26.0` -> `v1.27.0` | | [terraform-linters/tflint](https://togithub.com/terraform-linters/tflint) | minor | `v0.48.0` -> `v0.49.0` | | [twpayne/chezmoi](https://togithub.com/twpayne/chezmoi) | minor | `v2.40.4` -> `v2.41.0` | | [zellij-org/zellij](https://togithub.com/zellij-org/zellij) | patch | `v0.39.0` -> `v0.39.1` | --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.88.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.88.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.87.0...v4.88.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.88.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.88.0) | aquaproj/aqua-registry@v4.87.0...v4.88.0 #### 🎉 New Packages [#​17444](https://togithub.com/aquaproj/aqua-registry/issues/17444) [#​17449](https://togithub.com/aquaproj/aqua-registry/issues/17449) [kyoh86/richgo](https://togithub.com/kyoh86/richgo): Enrich `go test` outputs with text decorations [#​17437](https://togithub.com/aquaproj/aqua-registry/issues/17437) [#​17450](https://togithub.com/aquaproj/aqua-registry/issues/17450) [mpalmer/action-validator](https://togithub.com/mpalmer/action-validator): Tool to validate GitHub Action and Workflow YAML files #### Fixes [#​17447](https://togithub.com/aquaproj/aqua-registry/issues/17447) Melkeydev/go-blueprint: Follow up changes of go-blueprint v0.3.0 ### [`v4.87.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.87.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.86.1...v4.87.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.87.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.87.0) | aquaproj/aqua-registry@v4.86.1...v4.87.0 #### 🎉 New Packages [#​17417](https://togithub.com/aquaproj/aqua-registry/issues/17417) [aptly-dev/aptly](https://togithub.com/aptly-dev/aptly): Debian repository management tool [@​takumin](https://togithub.com/takumin) aqua >= v2.13.0 is required #### Fixes [#​17419](https://togithub.com/aquaproj/aqua-registry/issues/17419) suzuki-shunsuke/circleci-config-merge: Follow up changes of circleci-config-merge v1.1.6 ### [`v4.86.1`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.86.1) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.86.0...v4.86.1) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.86.1) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.86.1) | aquaproj/aqua-registry@v4.86.0...v4.86.1 ##### Fixes [#​17380](https://togithub.com/aquaproj/aqua-registry/issues/17380) noborus/xlsxsql: Follow up changes of xlsxsql v0.2.0 noborus/xlsxsql@4dd298b [#​17398](https://togithub.com/aquaproj/aqua-registry/issues/17398) [#​17399](https://togithub.com/aquaproj/aqua-registry/issues/17399) [#​17400](https://togithub.com/aquaproj/aqua-registry/issues/17400) [#​17401](https://togithub.com/aquaproj/aqua-registry/issues/17401) k0kubun/sqldef/{sqlite3def,mssqldef,mysqldef,psqldef} The GitHub Repository [k0kubun/sqldef](https://togithub.com/k0kubun/sqldef) was transferred to [sqldef/sqldef](https://togithub.com/sqldef/sqldef) ### [`v4.86.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.86.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.85.0...v4.86.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.86.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.86.0) | aquaproj/aqua-registry@v4.85.0...v4.86.0 #### 🎉 New Packages [#​17327](https://togithub.com/aquaproj/aqua-registry/issues/17327) [noborus/xlsxsql](https://togithub.com/noborus/xlsxsql): Execute SQL on xlsx file [@​ponkio-o](https://togithub.com/ponkio-o) #### Fixes [#​17338](https://togithub.com/aquaproj/aqua-registry/issues/17338) bitnami/charts-syncer: Follow up changes of charts-syncer v0.20.2 #### Fix transferred repositories [#​17326](https://togithub.com/aquaproj/aqua-registry/issues/17326) github/hub: Transfer the repository to mislav/hub [#​17325](https://togithub.com/aquaproj/aqua-registry/issues/17325) ellie/atuin: Transfer the repository to atuinsh/atuin [#​17324](https://togithub.com/aquaproj/aqua-registry/issues/17324) bitnami-labs/charts-syncer: Transfer the repository to bitnami/charts-syncer [#​17323](https://togithub.com/aquaproj/aqua-registry/issues/17323) batchcorp/plumber: Transfer the repository to streamdal/plumber [#​17320](https://togithub.com/aquaproj/aqua-registry/issues/17320) anqiansong/github-compare: Tranfer the repository to kesonan/github-compare [#​17315](https://togithub.com/aquaproj/aqua-registry/issues/17315) kubernetes-sigs/kubefed: Transfer the repository to kubernetes-retired/kubefed [#​17314](https://togithub.com/aquaproj/aqua-registry/issues/17314) knipferrc/fm: Transfer the repository to mistakenelf/fm [#​17305](https://togithub.com/aquaproj/aqua-registry/issues/17305) jdxcode/rtx: Transfer the repository to jdx/rtx Finally, we succeeded in automatic fix of aqua-registry's packages whose GitHub Repositories were transferred 🎉 This is the list of created pull requests. https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+is%3Aclosed+transfer+author%3Aapp%2Faquaproj-aqua-registry+is%3Amerged - example: [aquaproj/aqua-registry#17326 Please see the example, then you would understand what we did. A lot of aqua packages are associated with GitHub Repositories. But sometimes GitHub Repositories are transferred. If GitHub Repositories were transferred, we need to fix aqua-registry. We automated the fix! ### [`v4.85.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.85.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.84.0...v4.85.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.85.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.85.0) | aquaproj/aqua-registry@v4.84.0...v4.85.0 #### 🎉 New Packages [#​17271](https://togithub.com/aquaproj/aqua-registry/issues/17271) [#​17279](https://togithub.com/aquaproj/aqua-registry/issues/17279) [acheronfail/repgrep](https://togithub.com/acheronfail/repgrep): An interactive replacer for ripgrep that makes it easy to find and replace across files on the command line [#​17299](https://togithub.com/aquaproj/aqua-registry/issues/17299) [ismaelgv/rnr](https://togithub.com/ismaelgv/rnr): A command-line tool to batch rename files and directories [@​CrystalMethod](https://togithub.com/CrystalMethod) [#​17304](https://togithub.com/aquaproj/aqua-registry/issues/17304) [suzuki-shunsuke/ghcp](https://togithub.com/suzuki-shunsuke/ghcp): Tool to fork a repository, commit files, create a pull request and upload assets using GitHub API #### Fixes [#​17265](https://togithub.com/aquaproj/aqua-registry/issues/17265) Melkeydev/go-blueprint: Follow up changes of go-blueprint v0.2.11 ### [`v4.84.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.84.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.83.0...v4.84.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.84.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.84.0) | aquaproj/aqua-registry@v4.83.0...v4.84.0 #### 🎉 New Packages [#​17257](https://togithub.com/aquaproj/aqua-registry/issues/17257) [Melkeydev/go-blueprint](https://togithub.com/Melkeydev/go-blueprint): Go-blueprint allows users to spin up a quick Go project using a popular framework [@​CrystalMethod](https://togithub.com/CrystalMethod) [#​17260](https://togithub.com/aquaproj/aqua-registry/issues/17260) [Mikescher/better-docker-ps](https://togithub.com/Mikescher/better-docker-ps): Because `docker ps` is annoying and does not fit my monitor/terminal width [@​CrystalMethod](https://togithub.com/CrystalMethod) [#​17243](https://togithub.com/aquaproj/aqua-registry/issues/17243) [Piturnah/gex](https://togithub.com/Piturnah/gex): Git Explorer: cross-platform git workflow improvement tool inspired by Magit [@​CrystalMethod](https://togithub.com/CrystalMethod) #### Others [#​17239](https://togithub.com/aquaproj/aqua-registry/issues/17239) Fix sha256 of aqua-installer [@​CrystalMethod](https://togithub.com/CrystalMethod) ### [`v4.83.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.83.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.82.0...v4.83.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.83.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.83.0) | aquaproj/aqua-registry@v4.82.0...v4.83.0 #### 🎉 New Packages [#​17231](https://togithub.com/aquaproj/aqua-registry/issues/17231) [Macchina-CLI/macchina](https://togithub.com/Macchina-CLI/macchina): A system information frontend with an emphasis on performance [@​CrystalMethod](https://togithub.com/CrystalMethod) #### Fixes [#​17224](https://togithub.com/aquaproj/aqua-registry/issues/17224) kubernetes-sigs/zeitgeist: Follow up changes of zeitgeist v0.4.2 </details> <details> <summary>bitnami-labs/sealed-secrets (bitnami-labs/sealed-secrets)</summary> ### [`v0.24.4`](https://togithub.com/bitnami-labs/sealed-secrets/blob/HEAD/RELEASE-NOTES.md#v0244) [Compare Source](https://togithub.com/bitnami-labs/sealed-secrets/compare/v0.24.3...v0.24.4) ##### Changelog - kubeseal: write help message to stdout ([#​1377](https://togithub.com/bitnami-labs/sealed-secrets/pull/1377)) - fix: Set up LastTransitionTime in case that it is empty ([#​1370](https://togithub.com/bitnami-labs/sealed-secrets/pull/1370)) - Bump github.com/onsi/gomega from 1.29.0 to 1.30.0 ([#​1376](https://togithub.com/bitnami-labs/sealed-secrets/pull/1376)) - Bump golang.org/x/crypto from 0.14.0 to 0.15.0 ([#​1375](https://togithub.com/bitnami-labs/sealed-secrets/pull/1375)) - Bump github.com/onsi/ginkgo/v2 from 2.13.0 to 2.13.1 ([#​1374](https://togithub.com/bitnami-labs/sealed-secrets/pull/1374)) - Bump k8s.io/klog/v2 from 2.100.1 to 2.110.1 ([#​1367](https://togithub.com/bitnami-labs/sealed-secrets/pull/1367)) </details> <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.39.1`](https://togithub.com/cli/cli/releases/tag/v2.39.1): GitHub CLI 2.39.1 [Compare Source](https://togithub.com/cli/cli/compare/v2.39.0...v2.39.1) #### What's Changed - Fix executable location by [@​xqm32](https://togithub.com/xqm32) in [cli/cli#8238 - Query project item status field properly by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#8332 #### New Contributors - [@​xqm32](https://togithub.com/xqm32) made their first contribution in [cli/cli#8238 **Full Changelog**: cli/cli@v2.39.0...v2.39.1 ### [`v2.39.0`](https://togithub.com/cli/cli/releases/tag/v2.39.0): GitHub CLI 2.39.0 [Compare Source](https://togithub.com/cli/cli/compare/v2.38.0...v2.39.0) #### What's Changed - `release create`: Fix `--latest` flag behavior when creating release wth assets by [@​arunsathiya](https://togithub.com/arunsathiya) in [cli/cli#8207 - `issue`/`pr`: Include project item status when exporting issues and pull requests by [@​mattruggio](https://togithub.com/mattruggio) in [cli/cli#8202 - `codespace`: Resolve race condition in codespaces connection by [@​dmgardiner25](https://togithub.com/dmgardiner25) in [cli/cli#8275 - `release download`: Improve usage documentation by [@​muzimuzhi](https://togithub.com/muzimuzhi) in [cli/cli#8294 - `run view`: Simplify annotation fetch error handling by [@​williammartin](https://togithub.com/williammartin) in [cli/cli#8301 - `api`: Set default Accept header when one is not specified by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#8303 - build(deps): bump github.com/henvic/httpretty from 0.1.2 to 0.1.3 by [@​dependabot](https://togithub.com/dependabot) in [cli/cli#8286 #### New Contributors - [@​mattruggio](https://togithub.com/mattruggio) made their first contribution in [cli/cli#8202 - [@​muzimuzhi](https://togithub.com/muzimuzhi) made their first contribution in [cli/cli#8294 **Full Changelog**: cli/cli@v2.38.0...v2.39.0 </details> <details> <summary>derailed/k9s (derailed/k9s)</summary> ### [`v0.28.2`](https://togithub.com/derailed/k9s/releases/tag/v0.28.2) [Compare Source](https://togithub.com/derailed/k9s/compare/v0.28.1...v0.28.2) <img src="https://raw.githubusercontent.com/derailed/k9s/master/assets/k9s.png" align="center" width="800" height="auto"/> ### Release v0.28.2 #### Notes Thank you to all that contributed with flushing out issues and enhancements for K9s! I'll try to mark some of these issues as fixed. But if you don't mind grab the latest rev and see if we're happier with some of the fixes! If you've filed an issue please help me verify and close. Your support, kindness and awesome suggestions to make K9s better are, as ever, very much noted and appreciated! Also big thanks to all that have allocated their own time to help others on both slack and on this repo!! As you may know, K9s is not pimped out by corps with deep pockets, thus if you feel K9s is helping your Kubernetes journey, please consider joining our [sponsorship program](https://togithub.com/sponsors/derailed) and/or make some noise on social! [@​kitesurfer](https://twitter.com/kitesurfer) On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_invite/enQtOTA5MDEyNzI5MTU0LWQ1ZGI3MzliYzZhZWEyNzYxYzA3NjE0YTk1YmFmNzViZjIyNzhkZGI0MmJjYzhlNjdlMGJhYzE2ZGU1NjkyNTM) *** #### ♫ Sounds Behind The Release ♭ - [If Trouble Was Money - Albert Collins](https://www.youtube.com/watch?v=cz6LbWWqX-g) - [Old Love - Eric Clapton](https://www.youtube.com/watch?v=EklciRHZnUQ) - [Touch And GO - The Cars](https://www.youtube.com/watch?v=L7Gpr_Auz8Y) *** #### A Word From Our Sponsors... To all the good folks below that opted to `pay it forward` and join our sponsorship program, I salute you!! - [Bradley Heilbrun](https://togithub.com/bheilbrun) > Sponsorship cancellations since the last release: `2` ;( *** #### Feature Release ##### Sanitize Me! Over time, you might end up with a lot of pod cruft on your cluster. Pods that might be completed, erroring out, etc... Once you've completed your pod analysis it could be useful to clear out these pods from your cluster. In this drop, we introduce a new command `sanitize` aka `z` available on pod views otherwise known as `The Axe!`. This command performs a clean up of all pods that are in either in completed, crashloopBackoff or failed state. This could be especially handy if you run workflows jobs or commands on your cluster that might leave lots of `turd` pods. Tho this has a `phat` fail safe dialog please be careful with this one as it is a blunt tool! *** #### Resolved Issues - [Issue #​2281](https://togithub.com/derailed/k9s/issues/2281) Can't run Node shell - [Issue #​2277](https://togithub.com/derailed/k9s/issues/2277) bulk actions applied to power filters - [Issue #​2273](https://togithub.com/derailed/k9s/issues/2273) Error when draining node that is cordoned bug - [Issue #​2233](https://togithub.com/derailed/k9s/issues/2233) Invalid port-forwarding status displayed over the k9s UI *** #### Contributed PRs Please be sure to give `Big Thanks!` and `ATTA Girls/Boys!` to all the fine contributors for making K9s better for all of us!! - [PR #​2280](https://togithub.com/derailed/k9s/pull/2280) chore: replace github.com/ghodss/yaml with sigs.k8s. - [PR #​2278](https://togithub.com/derailed/k9s/pull/2278) README.md: fix typo in netshoot URL - [PR #​2275](https://togithub.com/derailed/k9s/pull/2275) check if the Node already cordoned when executing Drain - [PR #​2247](https://togithub.com/derailed/k9s/pull/2247) Delete port forwards when pods get deleted *** <img src="https://raw.githubusercontent.com/derailed/k9s/master/assets/imhotep_logo.png" width="32" height="auto"/> © 2023 Imhotep Software LLC. All materials licensed under [Apache v2.0](http://www.apache.org/licenses/LICENSE-2.0) ### [`v0.28.1`](https://togithub.com/derailed/k9s/releases/tag/v0.28.1) [Compare Source](https://togithub.com/derailed/k9s/compare/v0.28.0...v0.28.1) <img src="https://raw.githubusercontent.com/derailed/k9s/master/assets/k9s.png" align="center" width="800" height="auto"/> ### Release v0.28.1 #### Notes Thank you to all that contributed with flushing out issues and enhancements for K9s! I'll try to mark some of these issues as fixed. But if you don't mind grab the latest rev and see if we're happier with some of the fixes! If you've filed an issue please help me verify and close. Your support, kindness and awesome suggestions to make K9s better are, as ever, very much noted and appreciated! Also big thanks to all that have allocated their own time to help others on both slack and on this repo!! As you may know, K9s is not pimped out by corps with deep pockets, thus if you feel K9s is helping your Kubernetes journey, please consider joining our [sponsorship program](https://togithub.com/sponsors/derailed) and/or make some noise on social! [@​kitesurfer](https://twitter.com/kitesurfer) On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_invite/enQtOTA5MDEyNzI5MTU0LWQ1ZGI3MzliYzZhZWEyNzYxYzA3NjE0YTk1YmFmNzViZjIyNzhkZGI0MmJjYzhlNjdlMGJhYzE2ZGU1NjkyNTM) *** #### ♫ Sounds Behind The Release ♭ - [If Trouble Was Money - Albert Collins](https://www.youtube.com/watch?v=cz6LbWWqX-g) - [Old Love - Eric Clapton](https://www.youtube.com/watch?v=EklciRHZnUQ) - [Touch And GO - The Cars](https://www.youtube.com/watch?v=L7Gpr_Auz8Y) *** #### A Word From Our Sponsors... To all the good folks below that opted to `pay it forward` and join our sponsorship program, I salute you!! - [Bradley Heilbrun](https://togithub.com/bheilbrun) > Sponsorship cancellations since the last release: `2` ;( *** #### Feature Release ##### Sanitize Me! Over time, you might end up with a lot of pod cruft on your cluster. Pods that might be completed, erroring out, etc... Once you've completed your pod analysis it could be useful to clear out these pods from your cluster. In this drop, we introduce a new command `sanitize` aka `z` available on pod views otherwise known as `The Axe!`. This command performs a clean up of all pods that are in either in completed, crashloopBackoff or failed state. This could be especially handy if you run workflows jobs or commands on your cluster that might leave lots of `turd` pods. Tho this has a `phat` fail safe dialog please be careful with this one as it is a blunt tool! *** #### Resolved Issues - [Issue #​2281](https://togithub.com/derailed/k9s/issues/2281) Can't run Node shell - [Issue #​2277](https://togithub.com/derailed/k9s/issues/2277) bulk actions applied to power filters - [Issue #​2273](https://togithub.com/derailed/k9s/issues/2273) Error when draining node that is cordoned bug - [Issue #​2233](https://togithub.com/derailed/k9s/issues/2233) Invalid port-forwarding status displayed over the k9s UI *** #### Contributed PRs Please be sure to give `Big Thanks!` and `ATTA Girls/Boys!` to all the fine contributors for making K9s better for all of us!! - [PR #​2280](https://togithub.com/derailed/k9s/pull/2280) chore: replace github.com/ghodss/yaml with sigs.k8s. - [PR #​2278](https://togithub.com/derailed/k9s/pull/2278) README.md: fix typo in netshoot URL - [PR #​2275](https://togithub.com/derailed/k9s/pull/2275) check if the Node already cordoned when executing Drain - [PR #​2247](https://togithub.com/derailed/k9s/pull/2247) Delete port forwards when pods get deleted *** <img src="https://raw.githubusercontent.com/derailed/k9s/master/assets/imhotep_logo.png" width="32" height="auto"/> © 2023 Imhotep Software LLC. All materials licensed under [Apache v2.0](http://www.apache.org/licenses/LICENSE-2.0) </details> <details> <summary>junegunn/fzf (junegunn/fzf)</summary> ### [`v0.44.1`](https://togithub.com/junegunn/fzf/blob/HEAD/CHANGELOG.md#0441) [Compare Source](https://togithub.com/junegunn/fzf/compare/0.44.0...0.44.1) - Fixed crash when preview window is hidden on `focus` event ### [`v0.44.0`](https://togithub.com/junegunn/fzf/blob/HEAD/CHANGELOG.md#0440) [Compare Source](https://togithub.com/junegunn/fzf/compare/0.43.0...0.44.0) - (Experimental) Sixel image support in preview window (not available on Windows) - [bin/fzf-preview.sh](bin/fzf-preview.sh) is added to demonstrate how to display an image using Kitty image protocol or Sixel. You can use it like so: ```sh fzf --preview='fzf-preview.sh {}' ``` - (Experimental) iTerm2 inline image protocol support in preview window (not available on Windows) ```sh ``` </details> <details> <summary>kevincobain2000/gobrew (kevincobain2000/gobrew)</summary> ### [`v1.9.9`](https://togithub.com/kevincobain2000/gobrew/releases/tag/v1.9.9) [Compare Source](https://togithub.com/kevincobain2000/gobrew/compare/v1.9.7...v1.9.9) #### Changelog - [`4cee4c2`](https://togithub.com/kevincobain2000/gobrew/commit/4cee4c2) mod has - stopping to make release. After this release the bug will be fixed ### [`v1.9.7`](https://togithub.com/kevincobain2000/gobrew/releases/tag/v1.9.7) [Compare Source](https://togithub.com/kevincobain2000/gobrew/compare/v1.9.6...v1.9.7) #### Changelog - [`8cbdd91`](https://togithub.com/kevincobain2000/gobrew/commit/8cbdd91) Merge pull request [#​151](https://togithub.com/kevincobain2000/gobrew/issues/151) from kevincobain2000/kevincobain2000-patch-1 - [`877885a`](https://togithub.com/kevincobain2000/gobrew/commit/877885a) Merge pull request [#​152](https://togithub.com/kevincobain2000/gobrew/issues/152) from kevincobain2000/feature/limit-ci - [`f6903ad`](https://togithub.com/kevincobain2000/gobrew/commit/f6903ad) Merge pull request [#​153](https://togithub.com/kevincobain2000/gobrew/issues/153) from kevincobain2000/feature/obsolete - [`4f13840`](https://togithub.com/kevincobain2000/gobrew/commit/4f13840) Merge pull request [#​154](https://togithub.com/kevincobain2000/gobrew/issues/154) from kevincobain2000/kevincobain2000-patch-1 - [`f83b038`](https://togithub.com/kevincobain2000/gobrew/commit/f83b038) Merge pull request [#​155](https://togithub.com/kevincobain2000/gobrew/issues/155) from kevincobain2000/feature/mod-bug - [`ff9c9e8`](https://togithub.com/kevincobain2000/gobrew/commit/ff9c9e8) Update README.md - header img - [`9680c45`](https://togithub.com/kevincobain2000/gobrew/commit/9680c45) Update coveritup.yml - [`48fb44e`](https://togithub.com/kevincobain2000/gobrew/commit/48fb44e) Update git.io.sh - [`5d396a4`](https://togithub.com/kevincobain2000/gobrew/commit/5d396a4) push too - [`e2346cc`](https://togithub.com/kevincobain2000/gobrew/commit/e2346cc) run when needed - [`879dfb2`](https://togithub.com/kevincobain2000/gobrew/commit/879dfb2) script no longer needed - [`3a05718`](https://togithub.com/kevincobain2000/gobrew/commit/3a05718) unable to obtain mod version </details> <details> <summary>kubernetes/kubectl (kubernetes/kubectl)</summary> ### [`v1.28.4`](https://togithub.com/kubernetes/kubectl/compare/kubernetes-1.28.3...kubernetes-1.28.4) [Compare Source](https://togithub.com/kubernetes/kubectl/compare/kubernetes-1.28.3...kubernetes-1.28.4) </details> <details> <summary>nektos/act (nektos/act)</summary> ### [`v0.2.54`](https://togithub.com/nektos/act/releases/tag/v0.2.54) [Compare Source](https://togithub.com/nektos/act/compare/v0.2.53...v0.2.54) #### Changelog ##### New Features - [`04011b6`](https://togithub.com/nektos/act/commit/04011b6) feat: support runs-on labels and group ([#​2062](https://togithub.com/nektos/act/issues/2062)) ##### Bug fixes - [`74b0fe8`](https://togithub.com/nektos/act/commit/74b0fe8) fix: ([#​2075](https://togithub.com/nektos/act/issues/2075)) - [`5a79256`](https://togithub.com/nektos/act/commit/5a79256) fix: panic ([#​2071](https://togithub.com/nektos/act/issues/2071)) ##### Other - [`7693697`](https://togithub.com/nektos/act/commit/7693697) chore: bump VERSION to 0.2.54 - [`4dcb9b7`](https://togithub.com/nektos/act/commit/4dcb9b7) build(deps): bump golang.org/x/term from 0.13.0 to 0.14.0 ([#​2091](https://togithub.com/nektos/act/issues/2091)) - [`5547789`](https://togithub.com/nektos/act/commit/5547789) Evaluate if condition when calling a reusable workflow ([#​2087](https://togithub.com/nektos/act/issues/2087)) - [`c8f847d`](https://togithub.com/nektos/act/commit/c8f847d) Evaluate all service values ([#​2054](https://togithub.com/nektos/act/issues/2054)) - [`18b4714`](https://togithub.com/nektos/act/commit/18b4714) Don't set GITHUB_TOKEN ([#​2089](https://togithub.com/nektos/act/issues/2089)) - [`610358e`](https://togithub.com/nektos/act/commit/610358e) Support array expressions in runs-on ([#​2088](https://togithub.com/nektos/act/issues/2088)) - [`1c16fd1`](https://togithub.com/nektos/act/commit/1c16fd1) Use unique name for reusable workflow ([#​2015](https://togithub.com/nektos/act/issues/2015)) - [`55b09a0`](https://togithub.com/nektos/act/commit/55b09a0) build(deps): bump github.com/spf13/cobra from 1.7.0 to 1.8.0 ([#​2079](https://togithub.com/nektos/act/issues/2079)) </details> <details> <summary>simulot/immich-go (simulot/immich-go)</summary> ### [`v0.8.3`](https://togithub.com/simulot/immich-go/releases/tag/0.8.3) [Compare Source](https://togithub.com/simulot/immich-go/compare/0.8.2...0.8.3) #### Changelog - [`bc6f066`](https://togithub.com/simulot/immich-go/commit/bc6f066) Merge branch 'feature-[#​58](https://togithub.com/simulot/immich-go/issues/58)---add-filter-on-directories-during-the-import' into [Fix-for-#​69](https://togithub.com/Fix-for-/immich-go/issues/69)----Panic--runtime-error--slice-bounds-out-of-range---29-- - [`c62e7a0`](https://togithub.com/simulot/immich-go/commit/c62e7a0) add trimpath to goreleaser.ymal - [`d4442af`](https://togithub.com/simulot/immich-go/commit/d4442af) fix for [#​69](https://togithub.com/simulot/immich-go/issues/69): Panic: runtime error: slice bounds out of range - [`a5bed00`](https://togithub.com/simulot/immich-go/commit/a5bed00) implement nologger - [`d69c11a`](https://togithub.com/simulot/immich-go/commit/d69c11a) move the logger package at root of the project - [`df77d9b`](https://togithub.com/simulot/immich-go/commit/df77d9b) wip [#​69](https://togithub.com/simulot/immich-go/issues/69) - [`8df7277`](https://togithub.com/simulot/immich-go/commit/8df7277) wip [#​69](https://togithub.com/simulot/immich-go/issues/69) ### [`v0.8.2`](https://togithub.com/simulot/immich-go/releases/tag/0.8.2) [Compare Source](https://togithub.com/simulot/immich-go/compare/0.8.1...0.8.2) #### Changelog - [`0792ade`](https://togithub.com/simulot/immich-go/commit/0792ade) doc: edit releases.md - [`20e3422`](https://togithub.com/simulot/immich-go/commit/20e3422) fix for [#​61](https://togithub.com/simulot/immich-go/issues/61): album must have name error - [`fb9b7fb`](https://togithub.com/simulot/immich-go/commit/fb9b7fb) fix for [#​64](https://togithub.com/simulot/immich-go/issues/64) segfault - [`cc58567`](https://togithub.com/simulot/immich-go/commit/cc58567) wip: fix for segfault </details> <details> <summary>stern/stern (stern/stern)</summary> ### [`v1.27.0`](https://togithub.com/stern/stern/blob/HEAD/CHANGELOG.md#v1270) [Compare Source](https://togithub.com/stern/stern/compare/v1.26.0...v1.27.0) #### ⚡ Notable Changes ##### Add new template function: `toTimestamp` The `toTimestamp` function takes in an object, a layout, and optionally a timezone. This allows for more custom time parsing, for instance, if a user doesn't care about seeing the date of the log and only the time (in their own timezone) they can use a template such as: --template '{{ with $msg := .Message | tryParseJSON }}[{{ toTimestamp $msg.time "15:04:05" "Local" }}] {{ $msg.msg }}{{ end }}{{ "\n" }}' ##### Add generic kubectl options stern now has the generic options that kubectl has, and a new `--show-hidden-options` option. $ stern --show-hidden-options The following options can also be used in stern: --as string Username to impersonate for the operation. User could be a regular user or a service account in a namespace. --as-group stringArray Group to impersonate for the operation, this flag can be repeated to specify multiple groups. --as-uid string UID to impersonate for the operation. --cache-dir string Default cache directory (default "/home/ksuda/.kube/cache") --certificate-authority string Path to a cert file for the certificate authority --client-certificate string Path to a client certificate file for TLS --client-key string Path to a client key file for TLS --cluster string The name of the kubeconfig cluster to use --disable-compression If true, opt-out of response compression for all requests to the server --insecure-skip-tls-verify If true, the server's certificate will not be checked for validity. This will make your HTTPS connections insecure --request-timeout string The length of time to wait before giving up on a single server request. Non-zero values should contain a corresponding time unit (e.g. 1s, 2m, 3h). A value of zero means don't timeout requests. (default "0") --server string The address and port of the Kubernetes API server --tls-server-name string Server name to use for server certificate validation. If it is not provided, the hostname used to contact the server is used --token string Bearer token for authentication to the API server --user string The name of the kubeconfig user to use The number of kubectl generic options is so large that it makes it difficult to see stern's own list of options, so we usually hide them. Use `--show-hidden-options` if you want to list. #### Changes - Add generic cli options ([#​283](https://togithub.com/stern/stern/issues/283)) [`f315819`](https://togithub.com/stern/stern/commit/f315819) (Kazuki Suda) - 281: Support toTimestamp template function ([#​282](https://togithub.com/stern/stern/issues/282)) [`5445cd5`](https://togithub.com/stern/stern/commit/5445cd5) (Will Anderson) </details> <details> <summary>terraform-linters/tflint (terraform-linters/tflint)</summary> ### [`v0.49.0`](https://togithub.com/terraform-linters/tflint/releases/tag/v0.49.0) [Compare Source](https://togithub.com/terraform-linters/tflint/compare/v0.48.0...v0.49.0) #### What's Changed ##### Enhancements - build(deps): Bump github.com/terraform-linters/tflint-ruleset-terraform from 0.4.0 to 0.5.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1883 - This change updates the bundled terraform plugin version - feat(annotations): Allow a comment at the end of a tflint-ignore annotation by [@​papkos](https://togithub.com/papkos) in [terraform-linters/tflint#1892 - tflint: Allow config file to be set via `TFLINT_CONFIG_FILE` by [@​wata727](https://togithub.com/wata727) in [terraform-linters/tflint#1903 - tflint: Add `tflint-ignore-file` annotation by [@​wata727](https://togithub.com/wata727) in [terraform-linters/tflint#1909 ##### Chores - Add formula-path to follow formula path changes by [@​wata727](https://togithub.com/wata727) in [terraform-linters/tflint#1835 - build(deps): Bump sigstore/cosign-installer from 3.1.1 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1839 - build(deps): Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1838 - Fix go directive to include patch version by [@​wata727](https://togithub.com/wata727) in [terraform-linters/tflint#1842 - Replace golang.org/x/exp/slices to slices package by [@​wata727](https://togithub.com/wata727) in [terraform-linters/tflint#1836 - build(deps): Bump github.com/hashicorp/go-plugin from 1.4.10 to 1.5.1 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1846 - build(deps): Bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1843 - build(deps): Bump github.com/zclconf/go-cty from 1.13.2 to 1.14.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1845 - build(deps): Bump google.golang.org/grpc from 1.57.0 to 1.58.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1848 - Deprecate tflint-bundle image by [@​wata727](https://togithub.com/wata727) in [terraform-linters/tflint#1837 - build(deps): Bump google.golang.org/grpc from 1.58.0 to 1.58.1 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1850 - build(deps): Bump docker/build-push-action from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1851 - build(deps): Bump docker/login-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1852 - build(deps): Bump docker/setup-buildx-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1853 - build(deps): Bump docker/metadata-action from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1854 - build(deps): Bump goreleaser/goreleaser-action from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1855 - build(deps): Bump mislav/bump-homebrew-formula-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1861 - build(deps): Bump google.golang.org/grpc from 1.58.1 to 1.58.2 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1862 - build(deps): Bump github.com/spf13/afero from 1.9.5 to 1.10.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1863 - build(deps): Bump github.com/hashicorp/go-plugin from 1.5.1 to 1.5.2 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1864 - add test coverage for install script fail by [@​bendrucker](https://togithub.com/bendrucker) in [terraform-linters/tflint#1868 - install: move `-e` out of shebang by [@​ddelange](https://togithub.com/ddelange) in [terraform-linters/tflint#1870 - build(deps): Bump golang.org/x/oauth2 from 0.12.0 to 0.13.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1879 - build(deps): Bump github.com/zclconf/go-cty from 1.14.0 to 1.14.1 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1880 - build(deps): Bump github.com/hashicorp/hcl/v2 from 2.18.0 to 2.18.1 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1882 - build(deps): Bump golang.org/x/net from 0.16.0 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1884 - build(deps): Bump github.com/hashicorp/hcl/v2 from 2.18.1 to 2.19.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1885 - build(deps): Bump google.golang.org/grpc from 1.58.2 to 1.58.3 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1887 - build(deps): Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1886 - build(deps): Bump github.com/hashicorp/hcl/v2 from 2.19.0 to 2.19.1 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1890 - build(deps): Bump google.golang.org/grpc from 1.58.3 to 1.59.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1891 - build(deps): Bump github.com/google/uuid from 1.3.1 to 1.4.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1898 - build(deps): Bump github.com/fatih/color from 1.15.0 to 1.16.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1905 - build(deps): Bump golang.org/x/text from 0.13.0 to 0.14.0 by [@​dependabot](https://togithub.com/dependabot) in [terraform-linters/tflint#1906 #### New Contributors - [@​ddelange](https://togithub.com/ddelange) made their first contribution in [terraform-linters/tflint#1870 - [@​papkos](https://togithub.com/papkos) made their first contribution in [terraform-linters/tflint#1892 **Full Changelog**: terraform-linters/tflint@v0.48.0...v0.49.0 </details> <details> <summary>twpayne/chezmoi (twpayne/chezmoi)</summary> ### [`v2.41.0`](https://togithub.com/twpayne/chezmoi/releases/tag/v2.41.0) [Compare Source](https://togithub.com/twpayne/chezmoi/compare/v2.40.4...v2.41.0) #### Changelog ##### Features - [`26fd133`](https://togithub.com/twpayne/chezmoi/commit/26fd13319) feat: Add git-commit-message to generate command - [`c6688d2`](https://togithub.com/twpayne/chezmoi/commit/c6688d230) feat: Make commit message templates regular templates - [`f7c3745`](https://togithub.com/twpayne/chezmoi/commit/f7c3745bc) feat: Add git.commitMessageTemplateFile config variable - [`1f016e8`](https://togithub.com/twpayne/chezmoi/commit/1f016e8b0) feat: Add edit-config-template command ##### Fixes - [`d9cb6b0`](https://togithub.com/twpayne/chezmoi/commit/d9cb6b0cd) fix: Don't escape HTML characters in JSON strings ##### Documentation updates - [`b94f954`](https://togithub.com/twpayne/chezmoi/commit/b94f954cd) docs: Document support for the passage password manager - [`a1fba75`](https://togithub.com/twpayne/chezmoi/commit/a1fba7524) docs: add how-to for gpg ↔ age migration - [`8d58c3e`](https://togithub.com/twpayne/chezmoi/commit/8d58c3eba) docs: Fix default value of persistentState variable ##### Other - [`e8ed4c4`](https://togithub.com/twpayne/chezmoi/commit/e8ed4c462) refactor: Allow `mkdocs build` from any origin </details> <details> <summary>zellij-org/zellij (zellij-org/zellij)</summary> ### [`v0.39.1`](https://togithub.com/zellij-org/zellij/releases/tag/v0.39.1) [Compare Source](https://togithub.com/zellij-org/zellij/compare/v0.39.0...v0.39.1) This is a patch release to fix some issues that came out with the recent `0.39.0` release. The main user-facing issue here is reducing the serialization interval to 1 minute by default and allowing it to be configured using the `serialization_interval` configuration parameter. Thanks to the many community contributions which helped quickly fix a lot of the bugs found in the release! It's good to see so many people relying heavily on the tool and helping maintain it so quickly. #### What's Changed - Fix styled underlines in editors by [@​mike-lloyd03](https://togithub.com/mike-lloyd03) in [zellij-org/zellij#2918 - fix(ux): LaunchPlugin and some cwd fixes by [@​imsnif](https://togithub.com/imsnif) in [zellij-org/zellij#2916 - optimize: update refresh prorcess for sysinfo to reduce cpu usage by [@​xuanyuan300](https://togithub.com/xuanyuan300) in [zellij-org/zellij#2920 - Dropping to shell in command panes reuses CWD by [@​d-alonso](https://togithub.com/d-alonso) in [zellij-org/zellij#2915 - feat(config): add serialization interval configuration by [@​imsnif](https://togithub.com/imsnif) in [zellij-org/zellij#2923 - fix(plugins): reloading plugin after crash by [@​imsnif](https://togithub.com/imsnif) in [zellij-org/zellij#2929 #### New Contributors - [@​mike-lloyd03](https://togithub.com/mike-lloyd03) made their first contribution in [zellij-org/zellij#2918 - [@​xuanyuan300](https://togithub.com/xuanyuan300) made their first contribution in [zellij-org/zellij#2920 - [@​d-alonso](https://togithub.com/d-alonso) made their first contribution in [zellij-org/zellij#2915 **Full Changelog**: zellij-org/zellij@v0.39.0...v0.39.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/scottames/dots). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
On WSL2 Ubuntu (and possibly other Linux), Homebrew will use relative paths to establish symbolic links, which means that
t
in the following line of code will never be equal toexe
, which means that the executable function will always return os.Executable() execution results. This caused me to run into the same problem as #5482.cli/pkg/cmdutil/factory.go
Lines 85 to 87 in 5023b61
Therefore, I changed the method
os.ReadLink()
tofilepath.EvalSymlinks()
which behaves like the commandrealpath
.A demo
main.go
:Build and run it:
Fixes #5428