Improve completion by delegating to Click #25
Conversation
Previously we generated our own completions for available options and commands, in a similar way to how this was is done in the `click._bashcomplete` module. However, this module has had various improvements made to it since this was originally done. Rather than duplicate similar code here (and have to do this again in future), this commit changes our completion to delegate generating the available completions to Click. There is also additional handling around this to still display relevant help alongside the completions, where possible. The end result is that this commit should make click-repl's completion function as before, except with some additional completions shown where these are relevant, such as the completion of choices added in pallets/click#681. Any additional improvements to Click's completion will also become available to us.
|
That makes sense, however I wonder why this requires more LoC than the previous version. |
|
@untitaker: It requires more code mainly because we still need to do a lot of what we were doing already, to find the options and commands valid at the current context, in order to show their help alongside the completions. It probably wouldn't be much more if we could just delegate everything to Another reason for the increase is that there's longer comments now. |
|
Ok, please try to split this up into a few more functions, right now I'm having a hard time comprehending. |
|
Sure, good idea. I'll try to do that soon. |
|
closing due to inactivity |
Previously we generated our own completions for available options and commands, in a similar way to how this was is done in the
click._bashcompletemodule.However, this module has had various improvements made to it since this was originally done. Rather than duplicate similar code here (and have to do this again in future), this commit changes our completion to
delegate generating the available completions to Click. There is also additional handling around this to still display relevant help alongside the completions, where possible.
The end result is that this commit should make click-repl's completion function as before, except with some additional completions shown where these are relevant, such as the completion of choices added in
pallets/click#681. Any additional improvements to Click's completion will also become available to us.