Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve completion by delegating to Click #25

Closed

Commits on Apr 5, 2017

  1. Improve completion by delegating to Click

    Previously we generated our own completions for available options and
    commands, in a similar way to how this was is done in the
    `click._bashcomplete` module.
    
    However, this module has had various improvements made to it since this
    was originally done. Rather than duplicate similar code here (and have
    to do this again in future), this commit changes our completion to
    delegate generating the available completions to Click. There is also
    additional handling around this to still display relevant help alongside
    the completions, where possible.
    
    The end result is that this commit should make click-repl's completion
    function as before, except with some additional completions shown where
    these are relevant, such as the completion of choices added in
    pallets/click#681. Any additional improvements
    to Click's completion will also become available to us.
    bobwhitelock committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    55de328 View commit details
    Browse the repository at this point in the history